Closed Bug 1580138 Opened 5 months ago Closed 5 months ago

SSLTokensCache should be isolated by OriginAttributes

Categories

(Core :: Networking, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Currently, we only use host as the key to store the session cache.
To not reuse the session token from another container, we should use the same approach here to isolate the session token.

Blocks: 1560353
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/156e22161091
Use peer id to isolate token cache r=dragana,keeler

Backed out changeset 156e22161091 (Bug 1580138) for build bustage in toolkit/library/gtest/target.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=156e2216109101befdd9bfccf7262306ff009944

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268325799&repo=autoland&lineNumber=38217

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=3f5af5f49a1944fdd2e2d81b8ede2fabe3c2d358

[task 2019-09-25T10:42:28.878Z] 10:42:28     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -Qunused-arguments -U_FORTIFY_SOURCE -fno-common -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fsanitize=bool,bounds,vla-bound -fno-sanitize-recover=bool,bounds,vla-bound -fsanitize-blacklist=/builds/worker/workspace/build/src/obj-firefox/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -fno-common -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Werror  -fPIC -shared -Wl,--gc-sections -Wl,-h,libxul.so -o libxul.so /builds/worker/workspace/build/src/obj-firefox/toolkit/library/gtest/libxul_so.list   -lpthread -fsanitize=fuzzer-no-link -rdynamic -fsanitize=undefined -rdynamic -fsanitize=address -rdynamic -fuse-ld=gold -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro -Wl,-z,nocopyreloc -Wl,-Bsymbolic-functions -Wl,--build-id=sha1 -Wl,-Bsymbolic -Wl,-rpath-link,/builds/worker/workspace/build/src/obj-firefox/dist/bin -Wl,-rpath-link,/usr/local/lib   ../../../security/nss/lib/crmf/crmf_crmf/libcrmf.a ../../../js/src/build/libjs_static.a /builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/libgkrust_gtest.a ../../../config/external/nspr/pr/libnspr4.so ../../../config/external/nspr/libc/libplc4.so ../../../config/external/nspr/ds/libplds4.so ../../../config/external/lgpllibs/liblgpllibs.so ../../../security/nss/lib/nss/nss_nss3/libnss3.so ../../../security/nss/lib/util/util_nssutil3/libnssutil3.so ../../../security/nss/lib/smime/smime_smime3/libsmime3.so ../../../config/external/sqlite/libmozsqlite3.so ../../../security/nss/lib/ssl/ssl_ssl3/libssl3.so ../../../widget/gtk/mozgtk/stub/libmozgtk_stub.so ../../../widget/gtk/mozwayland/libmozwayland.so -Wl,--version-script,symverscript   -lpulse -lrt -lm -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lpthread -ldl -lc -lfreetype -lfontconfig -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0 -latk-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo-gobject -lpango-1.0 -lcairo -lgio-2.0 -lxcb-shm -lpangoft2-1.0 -lXt -lgthread-2.0
[task 2019-09-25T10:42:28.880Z] 10:42:28     INFO -  /builds/worker/workspace/build/src/obj-firefox/toolkit/library/gtest/../../../netwerk/base/FuzzySecurityInfo.o:FuzzySecurityInfo.cpp:vtable for mozilla::net::FuzzySecurityInfo: error: undefined reference to 'mozilla::net::FuzzySecurityInfo::GetPeerId(nsTSubstring<char>&)'
[task 2019-09-25T10:42:28.880Z] 10:42:28     INFO -  /builds/worker/workspace/build/src/obj-firefox/toolkit/library/gtest/../../../netwerk/base/FuzzySecurityInfo.o:FuzzySecurityInfo.cpp:vtable for mozilla::net::FuzzySecurityInfo: error: undefined reference to 'non-virtual thunk to mozilla::net::FuzzySecurityInfo::GetPeerId(nsTSubstring<char>&)'
[task 2019-09-25T10:42:28.880Z] 10:42:28     INFO -  clang-8: error: linker command failed with exit code 1 (use -v to see invocation)
[task 2019-09-25T10:42:28.880Z] 10:42:28     INFO -  /builds/worker/workspace/build/src/config/rules.mk:657: recipe for target 'libxul.so' failed
[task 2019-09-25T10:42:28.880Z] 10:42:28    ERROR -  make[4]: *** [libxul.so] Error 1
[task 2019-09-25T10:42:28.880Z] 10:42:28     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/gtest'
[task 2019-09-25T10:42:28.880Z] 10:42:28     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'toolkit/library/gtest/target' failed
[task 2019-09-25T10:42:28.880Z] 10:42:28    ERROR -  make[3]: *** [toolkit/library/gtest/target] Error 2
[task 2019-09-25T10:42:28.880Z] 10:42:28     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/rust'
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -  toolkit/library/rust/force-cargo-library-build
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -  /builds/worker/fetches/rustc/bin/cargo rustc  --release --frozen --manifest-path /builds/worker/workspace/build/src/toolkit/library/rust/Cargo.toml -vv --lib --target=x86_64-unknown-linux-gnu --features 'quantum_render cubeb_pulse_rust simd-accel cubeb-remoting moz_places spidermonkey_rust cranelift_x86 gecko_profiler gecko_profiler_parse_elf new_xulstore new_cert_storage fuzzing_interfaces' --  -Clto
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -         Fresh autocfg v0.1.2
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -         Fresh unicode-xid v0.1.0
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -         Fresh ident_case v1.0.0
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -         Fresh strsim v0.7.0
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -         Fresh fnv v1.0.6
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -         Fresh siphasher v0.2.1
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -         Fresh cc v1.0.34
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -         Fresh dtoa v0.4.2
[task 2019-09-25T10:48:37.184Z] 10:48:37     INFO -         Fresh rand_core v0.4.0
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh nodrop v0.1.12
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh glob v0.3.0
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh pkg-config v0.3.9
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh lazy_static v1.2.0
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh cfg-if v0.1.6
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh matches v0.1.6
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh itoa v0.4.1
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh scopeguard v1.0.0
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh procedural-masquerade v0.1.1
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh stable_deref_trait v1.0.0
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh slab v0.4.1
[task 2019-09-25T10:48:37.185Z] 10:48:37     INFO -         Fresh smallbitvec v2.3.0
[task 2019-09-25T10:48:37.186Z] 10:48:37     INFO -         Fresh futures v0.1.23
[task 2019-09-25T10:48:37.186Z] 10:48:37     INFO -         Fresh byte-tools v0.3.0
[task 2019-09-25T10:48:37.186Z] 10:48:37     INFO -         Fresh cranelift-entity v0.42.0 (https://github.com/CraneStation/Cranelift?rev=9c6f8feb0f28f50434c0cf67f3f7c07486a42b7e#9c6f8feb)
[task 2019-09-25T10:48:37.186Z] 10:48:37     INFO -         Fresh thin-slice v0.1.1
[task 2019-09-25T10:48:37.186Z] 10:48:37     INFO -         Fresh xml-rs v0.8.0
```
Flags: needinfo?(kershaw)

Forget to implement GetPeerId in FuzzySecurityInfo.cpp.

Flags: needinfo?(kershaw)
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a6d228bea61
Use peer id to isolate token cache r=dragana,keeler
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.