Closed Bug 1580174 Opened 3 months ago Closed 3 months ago

[wayland] popupnotification disappear when choosing microphone/video/screensharing source

Categories

(Core :: Widget: Gtk, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: jhorak, Assigned: jhorak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When using wayland backend:

  1. go to https://mozilla.github.io/webrtc-landing/gum_test.html
  2. Choose 'Audio&Video'
  3. dropdown the Camera to share: or Microphone to share:

Result: popupnotification window disappear and only the menu with selection opens. This breaks the dialog as long user is unable to click on Allow/Don't Allow.

Assignee: nobody → jhorak

Under Wayland where there's a strict popup window hierarchy, using toplevel window
for the submenus in popupnotification cause the popupnotification to hide
when opening them and this breaks user to Allow/Don't allow the action.

We have to use last opened popup window as a parent for these submenus.

Priority: -- → P2
Keywords: checkin-needed

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c62f6e70a74
Don't use toplevel window as parent for the menus in popupnotification; r=stransky

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Comment on attachment 9091725 [details]
Bug 1580174 - Don't use toplevel window as parent for the menus in popupnotification; r=stransky

Beta/Release Uplift Approval Request

  • User impact if declined: Some popups (screen sharing for instance) does not work under wayland.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only.
  • String changes made/needed: none
Attachment #9091725 - Flags: approval-mozilla-beta?
See Also: → 1581773

Comment on attachment 9091725 [details]
Bug 1580174 - Don't use toplevel window as parent for the menus in popupnotification; r=stransky

Wayland fix, approved for 70.0b8.

Attachment #9091725 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.