1580174 - [wayland] popupnotification disappear when choosing microphone/video/screensharing source

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Jan Horak [:jhorak]]

When using wayland backend:

1. go to https://mozilla.github.io/webrtc-landing/gum_test.html
2. Choose 'Audio&Video'
3. dropdown the Camera to share: or Microphone to share:

Result: popupnotification window disappear and only the menu with selection opens. This breaks the dialog as long user is unable to click on Allow/Don't Allow.

Comment 1

[Jan Horak [:jhorak]]

Attachment: Bug 1580174 - Don't use toplevel window as parent for the menus in popupnotification; r=stransky

Under Wayland where there's a strict popup window hierarchy, using toplevel window
for the submenus in popupnotification cause the popupnotification to hide
when opening them and this breaks user to Allow/Don't allow the action.

We have to use last opened popup window as a parent for these submenus.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c62f6e70a74
Don't use toplevel window as parent for the menus in popupnotification; r=stransky

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8c62f6e70a74

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9091725 [details]
Bug 1580174 - Don't use toplevel window as parent for the menus in popupnotification; r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: Some popups (screen sharing for instance) does not work under wayland.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only.
• String changes made/needed: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9091725 [details]
Bug 1580174 - Don't use toplevel window as parent for the menus in popupnotification; r=stransky

Wayland fix, approved for 70.0b8.

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c10339c29e4