1580181 - Don't manage evalWindow debuggee in webconsole actor's autocomplete function

Status: RESOLVED FIXED

(DevTools :: Console, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

We used to do that because the debugger instance we had wasn't adding debuggee for existing and future globals.
When Bug 1577798 lands, we should always have a debuggee for the eval window, so we don't need to add it and remove it inside the function.

We should probably not pass a debugger object to JsPropertyProvider, but only an environment.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1580181 - Remove debuggee existence check in webconsole actor autocomplete. r=ochameau.

We always have a debugee for the eval window, so we can
remove the now unnecessary check.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1580181 - Reorganize js-property-provider. r=ochameau.

Move analyzeInputString function below JSPropertyProvider, so
the exported function appears first in the file.

Depends on D49105

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d99d216edd0
Remove debuggee existence check in webconsole actor autocomplete. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/e967465ff815
Reorganize js-property-provider. r=ochameau.

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/0d99d216edd0
https://hg.mozilla.org/mozilla-central/rev/e967465ff815