Closed
Bug 1580181
Opened 5 years ago
Closed 5 years ago
Don't manage evalWindow debuggee in webconsole actor's autocomplete function
Categories
(DevTools :: Console, task, P1)
DevTools
Console
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(2 files)
We used to do that because the debugger instance we had wasn't adding debuggee for existing and future globals.
When Bug 1577798 lands, we should always have a debuggee for the eval window, so we don't need to add it and remove it inside the function.
We should probably not pass a debugger object to JsPropertyProvider
, but only an environment
.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Updated•5 years ago
|
Depends on: dt-fission-browser-console
Assignee | ||
Comment 1•5 years ago
|
||
We always have a debugee for the eval window, so we can
remove the now unnecessary check.
Assignee | ||
Comment 2•5 years ago
|
||
Move analyzeInputString function below JSPropertyProvider, so
the exported function appears first in the file.
Depends on D49105
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d99d216edd0 Remove debuggee existence check in webconsole actor autocomplete. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/e967465ff815 Reorganize js-property-provider. r=ochameau.
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0d99d216edd0
https://hg.mozilla.org/mozilla-central/rev/e967465ff815
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Updated•5 years ago
|
Blocks: dt-fission-browser-console
No longer depends on: dt-fission-browser-console
Updated•4 years ago
|
Whiteboard: dt-fission → dt-fission dt-fission-m1
Updated•3 years ago
|
Whiteboard: dt-fission dt-fission-m1 → dt-fission-m1
You need to log in
before you can comment on or make changes to this bug.
Description
•