Closed Bug 1580200 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18965 - Fix background-position-interpolation.html for initial/unset

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18965 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18965
Details from upstream follow.

Stephen McGruer <smcgruer@chromium.org> wrote:

Fix background-position-interpolation.html for initial/unset

The initial/unset value for background-position is 0% 0%, so any
interpolation from/to that involves a calc with a percentage in it. By
the calc spec, calcs with percentages in them are not resolved when
getting the computed value - even if the percentage is 0%.

The test shouldn't pass in Chrome after this CL, but does anyway as it
resolves the expected values to not include percentages either!

See https://bugzilla.mozilla.org/show_bug.cgi?id=1574913 for where we
discovered the test was wrong.

Bug: 1002430
Change-Id: Ibacb8f9e1745f13cd2fe92894ac0f8e67e3228fa
Reviewed-on: https://chromium-review.googlesource.com/1795842
WPT-Export-Revision: d2cb069b40525a6e3f42df260c44579f0e9d1bea

Component: web-platform-tests → Layout
Product: Testing → Core
Ran 1 tests and 196[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-opt] subtests
OK     : 1[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-opt]
PASS   : 65[windows7-32-opt], 140[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt], 135[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt]
CRASH  : 1[windows7-32-debug]
FAIL   : 56[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt], 131[windows7-32-opt], 61[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt]

Tests that CRASH:
/css/css-backgrounds/animations/background-position-interpolation.html: [windows7-32-debug]

New tests that have failures or other problems:
/css/css-backgrounds/animations/background-position-interpolation.html
    CSS Animations: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (-0.25) should be [calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px)]: FAIL[windows7-32-opt]
    CSS Animations: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.25) should be [calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px)]: FAIL[windows7-32-opt]
    CSS Animations: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.5) should be [calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px)]: FAIL[windows7-32-opt]
    CSS Animations: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.75) should be [calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px)]: FAIL[windows7-32-opt]
    CSS Animations: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (1.25) should be [calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px)]: FAIL[windows7-32-opt]
    CSS Animations: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (-0.25) should be [calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px)]: FAIL[windows7-32-opt]
    CSS Animations: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.25) should be [calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px)]: FAIL[windows7-32-opt]
    CSS Animations: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.5) should be [calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px)]: FAIL[windows7-32-opt]
    CSS Animations: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.75) should be [calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px)]: FAIL[windows7-32-opt]
    CSS Animations: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (1.25) should be [calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px)]: FAIL[windows7-32-opt]
    CSS Transitions with transition: all: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (-0.25) should be [calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px)]: FAIL[windows7-32-opt]
    CSS Transitions with transition: all: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.25) should be [calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px)]: FAIL[windows7-32-opt]
    CSS Transitions with transition: all: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.5) should be [calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px)]: FAIL[windows7-32-opt]
    CSS Transitions with transition: all: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.75) should be [calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px)]: FAIL[windows7-32-opt]
    CSS Transitions with transition: all: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (1.25) should be [calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px)]: FAIL[windows7-32-opt]
    CSS Transitions with transition: all: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (-0.25) should be [calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px)]: FAIL[windows7-32-opt]
    CSS Transitions with transition: all: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.25) should be [calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px)]: FAIL[windows7-32-opt]
    CSS Transitions with transition: all: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.5) should be [calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px)]: FAIL[windows7-32-opt]
    CSS Transitions with transition: all: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.75) should be [calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px)]: FAIL[windows7-32-opt]
    CSS Transitions with transition: all: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (1.25) should be [calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px)]: FAIL[windows7-32-opt]
    CSS Transitions: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (-0.25) should be [calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px)]: FAIL[windows7-32-opt]
    CSS Transitions: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.25) should be [calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px)]: FAIL[windows7-32-opt]
    CSS Transitions: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.5) should be [calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px)]: FAIL[windows7-32-opt]
    CSS Transitions: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.75) should be [calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px)]: FAIL[windows7-32-opt]
    CSS Transitions: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (1.25) should be [calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px)]: FAIL[windows7-32-opt]
    CSS Transitions: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (-0.25) should be [calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px), calc(0% - 20px) calc(0% - 20px)]: FAIL[windows7-32-opt]
    CSS Transitions: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.25) should be [calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px), calc(0% + 20px) calc(0% + 20px)]: FAIL[windows7-32-opt]
    CSS Transitions: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.5) should be [calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px)]: FAIL[windows7-32-opt]
    CSS Transitions: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.75) should be [calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px), calc(0% + 60px) calc(0% + 60px)]: FAIL[windows7-32-opt]
    CSS Transitions: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (1.25) should be [calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px), calc(0% + 100px) calc(0% + 100px)]: FAIL[windows7-32-opt]
    Web Animations: property <background-position> from [initial] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.5) should be [calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px)]: FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt]
    Web Animations: property <background-position> from [unset] to [80px 80px, 80px 80px, 80px 80px, 80px 80px] at (0.5) should be [calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px), calc(0% + 40px) calc(0% + 40px)]: FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/678333610aac
[wpt PR 18965] - Fix background-position-interpolation.html for initial/unset, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb7f84bff4e6
[wpt PR 18965] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.