1580212 - Make dom.ipc.keepProcessesAlive.webIsolated work with Fission content processes

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P2)

Description

[Andrew McCreight [:mccr8]]

Changing this seems to have a number of effects on tests, so I'm going to spin this out into a separate bug, in the hope that it will let me land bug 1579835 more quickly.

Comment 1

[Andrew McCreight [:mccr8]]

I wrote a patch to make the preference dom.ipc.keepProcessesAlive.webIsolated work for Fission remote processes, and enabled it for just the directory browser/components/extensions/test/browser/. This seems to "fix" bug 1576498 and maybe the instance of bug 1358898 that was happening in that directory, presumably by papering over whatever shutdown races or bad debug build slowdowns we were getting with so many content processes.

Comment 2

[Andrew McCreight [:mccr8]]

Here's a run without my patches, and here's a try run with a prototype version of my patches. I'll make sure my more targetted fix also works around the issues.

Comment 3

[Andrew McCreight [:mccr8]]

(3 failures in 5 runs without, 0 failures in 12 runs with.)

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1580212, part 1 - Drop the equal sign from FISSION_WEB_REMOTE_TYPE_PREFIX and add it to ContentParent.h.

Right now, this constant has an equal sign in it. I want to use it in
C++ without the equal sign in the next patch. So, for consistency,
move the equal sign to the places that use this constant. Also, add
the constant to C++.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1580212, part 2 - Make dom.ipc.keepProcessesAlive.webIsolated work for Fission content processes.

Also, enable it for the extensions test directory. Without this pref,
it gets frequent intermittent leaks and shutdown hangs when Fission is
enabled.

Comment 6

[Andrew McCreight [:mccr8]]

Try run where this version of the patch failed 0 out of 9 times: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9ffa2580aefc527ca143b5eed0aa5df38f4a60c

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/831b2d7f3b3d
part 1 - Drop the equal sign from FISSION_WEB_REMOTE_TYPE_PREFIX and add it to ContentParent.h. r=kmag
https://hg.mozilla.org/integration/autoland/rev/4ac52c8d0384
part 2 - Make dom.ipc.keepProcessesAlive.webIsolated work for Fission content processes. r=kmag

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/831b2d7f3b3d
https://hg.mozilla.org/mozilla-central/rev/4ac52c8d0384