Closed Bug 1580212 Opened 10 months ago Closed 8 months ago

Make dom.ipc.keepProcessesAlive.webIsolated work with Fission content processes

Categories

(Core :: DOM: Content Processes, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla72
Fission Milestone M4
Tracking Status
firefox72 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Changing this seems to have a number of effects on tests, so I'm going to spin this out into a separate bug, in the hope that it will let me land bug 1579835 more quickly.

Depends on: 1579897
Fission Milestone: --- → M4
Priority: -- → P2

I wrote a patch to make the preference dom.ipc.keepProcessesAlive.webIsolated work for Fission remote processes, and enabled it for just the directory browser/components/extensions/test/browser/. This seems to "fix" bug 1576498 and maybe the instance of bug 1358898 that was happening in that directory, presumably by papering over whatever shutdown races or bad debug build slowdowns we were getting with so many content processes.

Here's a run without my patches, and here's a try run with a prototype version of my patches. I'll make sure my more targetted fix also works around the issues.

(3 failures in 5 runs without, 0 failures in 12 runs with.)

Right now, this constant has an equal sign in it. I want to use it in
C++ without the equal sign in the next patch. So, for consistency,
move the equal sign to the places that use this constant. Also, add
the constant to C++.

Also, enable it for the extensions test directory. Without this pref,
it gets frequent intermittent leaks and shutdown hangs when Fission is
enabled.

Summary: Fix dom.ipc.keepProcessesAlive for webIsolated remote types → Make dom.ipc.keepProcessesAlive.webIsolated work with Fission content processes

Try run where this version of the patch failed 0 out of 9 times: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9ffa2580aefc527ca143b5eed0aa5df38f4a60c

Blocks: 1588618
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/831b2d7f3b3d
part 1 - Drop the equal sign from FISSION_WEB_REMOTE_TYPE_PREFIX and add it to ContentParent.h. r=kmag
https://hg.mozilla.org/integration/autoland/rev/4ac52c8d0384
part 2 - Make dom.ipc.keepProcessesAlive.webIsolated work for Fission content processes. r=kmag
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Blocks: 1594878
See Also: → 1595191
You need to log in before you can comment on or make changes to this bug.