1580218 - IPC callers of nsSHistory::EvictContentViewersOrReplaceEntry need to call `SHistoryChild::SetSHistory` in the child

Status: RESOLVED DUPLICATE of bug 1588491

(Core :: DOM: Navigation, defect, P3)

Comment 1

[Chris Peterson [:cpeterson]]

Roll some unfixed bugs from Fission Milestone M4 to M5

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 2

[Anny Gakhokidze [:annyG]]

In patch https://phabricator.services.mozilla.com/rMOZILLACENTRAL351e31cced31850983c9552b6f9a90dc69c3e5d8 I added a new IPC call EvictContentViewersOrReplaceEntry on SHistory to consolidate IPC calls nsSHistory::EvictOutOfRangeContentViewers, nsSHistory::GetIndexOfEntry and nsSHistory::ReplaceEntry. When we were calling those IPC calls from the child process, the calls would be routed first via SHistoryChild::EvictOutOfRangeContentViewers, SHistoryChild::GetIndexOfEntry and SHistoryChild::ReplaceEntry. In SHistoryChild::ReplaceEntry just before returning, we would execute the following thing aReplaceEntry->SetSHistory(this); https://searchfox.org/mozilla-central/rev/1d35a2c86b0f30f5cc4744222f5fb0901fed02b0/docshell/shistory/SHistoryChild.cpp#228 which I forgot to add to my new code path. However, it appears that in the latest version of the code we no longer have the call to SetSHistory. Peter, I think this means that this work is no longer required?

Comment 3

[Peter Van der Beken [:peterv]]

Yeah, bug 1588491 fixed this. I'm going to mark it duplicate.