Closed
Bug 1580228
Opened 5 years ago
Closed 5 years ago
Fix usage of nsIDocShellTreeItem in nsDocShell::EndPageLoad
Categories
(Core :: DOM: Navigation, defect, P2)
Core
DOM: Navigation
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: djvj, Assigned: djvj)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rm-docshell-tree-item:simple])
Attachments
(1 file, 1 obsolete file)
https://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.cpp#6590
This use in nsDocShell::EndPageLoad is pretty simple. The tree is simply checked to see if the parent exists, and the variable isTopFrame set on that basis. This needs to be changed to use the BrowsingContext tree to determine the isTopFrame flag instead.
|
||
Updated•5 years ago
|
Fission Milestone: --- → M5
Priority: -- → P2
|
Assignee | |
Updated•5 years ago
|
Whiteboard: [rm-docshell-tree-item:simple]
|
|
||
Updated•5 years ago
|
Fission Milestone: M5 → Future
|
||
Comment 1•5 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
Fission Milestone: Future → M6
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → kvijayan
Pushed by kvijayan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99d7e2c46514 Fix usage of nsIDocShellTreeItem in nsDocShell::EndPageLoad r=kmag
|
|
||
Updated•5 years ago
|
Attachment #9110065 -
Attachment is obsolete: true
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•