Closed Bug 1580296 Opened 5 years ago Closed 5 years ago

Picture caching doesn't work anymore on http://diana-adrianne.com/purecss-francine/ on Mac

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- verified

People

(Reporter: jrmuizel, Assigned: gw)

References

Details

(Keywords: regression)

STR:

turn on gfx.webrender.debug.picture-caching.
load http://diana-adrianne.com/purecss-francine/
observe a bunch of red when scrolling

Bug 1566901 was the previous incarnation of this work.

Flags: needinfo?(gwatson)

If I try this on current m-c, I see it occasionally invalidate during scrolling on the bottom tiles. Is that what you're seeing, or is it something different?

When I run with my dirty rects patch, which I'm hoping to land today / tomorrow (https://phabricator.services.mozilla.com/D45287) I don't see any invalidations occurring at all. So, it may be enough to wait until that lands and then re-check on your machine.

Flags: needinfo?(gwatson)

Sure, let's wait.

I tried this out with todays build and it was still really bad. Everything is red when I turn on picture cache debugging.

However on Linux I see only Green.

Summary: Picture caching doesn't work anymore on http://diana-adrianne.com/purecss-francine/ → Picture caching doesn't work anymore on http://diana-adrianne.com/purecss-francine/ on Mac

I tried this on a mac today.

I can see the tiles on the right hand side of the screen are constantly invalidating. It looks like the scroll bars are drawn in a different order on mac, which is tripping up some of the caching logic. On Linux, the scrollbars are excluded from the picture caching, so don't cause invalidations on the cached content. After some time, the dirty rects kick in and start only updating the scroll bar areas.

Does this match what you're seeing? It sounds a bit different, since I only see tiles on the right hand side of the screen invalidating. However, if your window is < 2048 device pixels wide, that would look the same, since that's the default tile width.

I'll investigate the scroll bar issue further this week and fix that up.

Assignee: nobody → gwatson

I opened https://phabricator.services.mozilla.com/D45970 as part 1 of the fix for this. Tagging the scroll bar primitives from Gecko will make it much simpler and more robust for picture caching to exclude scroll bars from the content or (in future) add scroll bars into a separate compositor slice.

I think this will be fixed once https://bugzilla.mozilla.org/show_bug.cgi?id=1581757 lands, however I'll leave it to Jeff to confirm - since there might be something else going on.

It's not an ideal fix, but it should work around the problem until we have https://bugzilla.mozilla.org/show_bug.cgi?id=1582273 and can take advantage of that in WR.

I believe this will be fixed when https://bugzilla.mozilla.org/show_bug.cgi?id=1584439 lands in m-c (it's on autoland now).

Is this working correctly on your mac now?

Flags: needinfo?(jmuizelaar)

Yes this works better now.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(jmuizelaar)
Resolution: --- → FIXED
Flags: qe-verify+
QA Contact: daniel.cicas

Reproduced the issue on Nightly 70.0a1.
Verified as fixed with Fx 71.0b7 and Nightly 72.0a1 on macOS 10.11, macOS 10.15.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.