Closed Bug 1580306 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18974 - [LayoutNG] Fix `vertical-align: top/bottom` with leading

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18974 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18974
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[LayoutNG] Fix vertical-align: top/bottom with leading

This patch fixes two behavior related with line-height when
vertical-align: top or bottom is used.

  1. Fixes boxes with vertical-align: top or bottom not to
    affect the height of the parent inline box.
    This is not a defined behavior but all 4 impls do this.
  2. Fixes non-culled inline boxes to take the line-height
    property into account when computing top or bottom of
    inline boxes in the line.

Bug: 1001418
Change-Id: Ia53b9894dd81e70e17588bc284f0df4bc4f5c382

Reviewed-on: https://chromium-review.googlesource.com/1795535
WPT-Export-Revision: fe48293016c37ead7905bf98dab60e8439c45d9a

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
PASS   : 1
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc0e67982766
[wpt PR 18974] - [LayoutNG] Fix `vertical-align: top/bottom` with leading, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bc0e67982766

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.