1580319 - gUM prompt with disabled "Allow" button. No way to proceed

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P1)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: DisabledAllow.png

STRs:

1. Open https://jan-ivar.github.io/dummy/gdm.html but don't answer the prompt (leave it open).
2. In a separate tab, open https://jsfiddle.net/jib1/pz5pynyf/

Expected result: A prompt with choices "Don't Allow" and "Allow"

Actual result: "Allow" choice is disabled, with no way to enable it (see screenshot).

Workaround: None. Closing the other tab and refreshing this tab does not bring the "Allow" button back for me. Once I'm in this state, I have to restart Firefox to get "Allow" enabled again.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

This appears to be another case where prompt state bleeds between tabs.

Comment 2

[Johann Hofmann [:johannh]]

Yuup, that doesn't look good.

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1580319 - Clear PopupNotifications UI state when no checkbox is present. r=prathiksha

In getUserMedia we didn't use to have prompts without a checkbox, thus this bug couldn't manifest.
Now we do hide the checkbox for iframes, so this code path is triggered and doesn't properly
reset the UI state between prompts.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09bdee778e59
Clear PopupNotifications UI state when no checkbox is present. r=prathiksha

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/09bdee778e59

Comment 7

[Johann Hofmann [:johannh]]

Jib, do you think we should uplift this to 70? The fix is relatively straightforward, though I'd give it a few days of bake time for the add-ons changes at least.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Fix LGTM on testing. The only issues I ran into were known bugs bug 1539938 and bug 1517030 which are low priority and not regressions.

Looks baked. I recommend uplift to 70 to avoid regressing release here. Wanna write the uplift request?

Comment 9

[Johann Hofmann [:johannh]]

Comment on attachment 9092788 [details]
Bug 1580319 - Clear PopupNotifications UI state when no checkbox is present. r=prathiksha

Beta/Release Uplift Approval Request

• User impact if declined: Users can break their camera/microphone prompts until restart by showing a screensharing prompt in another tab at the same time.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A relatively simple front-end patch, permission prompts are well covered with tests, has baked for a while on Nightly. Should probably still be verified by QA.
• String changes made/needed: None

Comment 10

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 71.0a1 (BuildId:20190910213950) on Windows 10 64bit.

This issue is verified fixed using Firefox 71.0a1 (BuildId:20190924215237) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 18.04 64bit.

Comment 11

[Emil Ghitta, QA [:emilghitta]]

Leaving a ni? and the qe-verify+ flag until this gets verified on beta as well (when time comes).

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9092788 [details]
Bug 1580319 - Clear PopupNotifications UI state when no checkbox is present. r=prathiksha

Thanks for the fast verify!
OK for uplift for beta 10.

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b4c4862002c6

Comment 14

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 70.0b10 (BuildId:20190926005616) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 18.04 64bit.