1580327 - Remove Private Internet Access logo from the home page

Status: RESOLVED FIXED

(SeaMonkey :: Website, enhancement)

Description

[RickieES aka Ricardo Palomares]

Attachment: website-patch.txt

The sponsorship of Private Internet Access has ended, so we need to remove the logo from the SeaMonkey home page. I'm providing a patch that just comments out the HTML code, in case we get a new sponsorship soon.

I don't really know who can review this, so I'm setting the needinfo flag.

Comment 1

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9091911 [details] [diff] [review]
website-patch.txt

Hi Rickie usually set IanN or me if you want a review. 

The image under src/images/PIALogo1x.png should go too. If we need it again we can pull it out of the hg history. The patch is also missing a proper header. We can fix it during check-in.

Comment 2

[RickieES aka Ricardo Palomares]

Hum... Sorry, I don't understand the proper header part. Do you mean the context lines around the change itself, using -U 8 perhaps on hg diff?

Comment 3

[Frank-Rainer Grahl (:frg)]

Convention is a header with email, bug # and description. If you use hg then hg qnew <patchfilename> should create a proper one e.g.
https://bug1580359.bmoattachments.org/attachment.cgi?id=9091980

https://www.mercurial-scm.org/wiki/MqTutorial

No big deal. I can do it for check-in but we usually tolerate it only for new contributors because more work for the one doing the check-ins :)

Comment 4

[RickieES aka Ricardo Palomares]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

Convention is a header with email, bug # and description. If you use hg then hg qnew <patchfilename> should create a proper one e.g.
https://bug1580359.bmoattachments.org/attachment.cgi?id=9091980

Sorry if I need further directions on this. Starting with this situation:

$ hg stat
M lib/sidebar.tmpl
R src/images/PIALogo1x.png

I've run this command:

$ hg qnew websitepatch.txt

I've got the text editor and written these lines:

HG changeset patch

User Ricardo Palomares <[e-mail]>

Parent 1374:13539a4ba536

Bug 1580327 - Remove Private Internet Access logo from the home page

OK, so now I don't have any websitepatch.txt, and hg stat, hg diff and hg qrefresh (and, again, hg stat and hg diff) return no output.

At this point, you probably want me to add here just the regular diff patch, but I want to learn how to do it properly from now on. What am I missing?

TIA

Comment 5

[Ian Neal]

Using:
hg qdiff

Should list what is in the patch and it should also show (and can be copied from) under .hg/patches

Regards

Comment 6

[RickieES aka Ricardo Palomares]

Attachment: Updated patch removing the binary image file and adding a header

New try, let's see if I've learned to do it right. :-)

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9094413 [details] [diff] [review]
Updated patch removing the binary image file and adding a header

Looks good. Usually I would remove the sponsored block too but we have a new one so we can reuse it soon.

Comment 8

[Frank-Rainer Grahl (:frg)]

Thanks you. Watch the site. Should be visible soon.
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/e152eadd8e7ea3db23b36a827e86d0fe35abaf1c