1580334 - Hovering on the timeline should update the debugger

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, enhancement, P3)

Description

[Jason Laster [:jlast]]

When the user hovers on the timeline, the debugger should immediately update to show where the program was at that point in time.

Comment 1

[Jason Laster [:jlast]]

This is a decent first attempt

diff --git a/devtools/client/webreplay/components/WebReplayPlayer.js b/devtools/client/webreplay/components/WebReplayPlayer.js
index a0c9cafc2750..8ea6e342b4b3 100644
--- a/devtools/client/webreplay/components/WebReplayPlayer.js
+++ b/devtools/client/webreplay/components/WebReplayPlayer.js
@@ -362,6 +362,8 @@ class WebReplayPlayer extends Component {
       return;
     }

+
+    this.toolbox.viewSourceInDebugger(closestMessage.frame.source, closestMessage.frame.url);
     this.paint(closestMessage.executionPoint);
   }

Comment 2

[Jason Laster [:jlast]]

Ideally, we'd use a new action to preview the paused location which would prompt the debugline to show the blue background over the token the program was at at that point in time.

Comment 3

[Jason Laster [:jlast]]

Currently, we can only update the debugger when the user hovers on a marker. To update the debugger generally, we'll need to be able to find sample points in the program that we can use. This is probably related to the control.js# findFrameSteps.

Comment 4

[Jason Laster [:jlast]]

Attachment: Bug 1580334 - Hovering on the timeline should update the debugger. r=bhackett

Comment 5

[Jason Laster [:jlast]]

Attachment: Bug 1580334 - Hovering on the timeline should update the debugger. r=bhackett

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1416218ae397
Hovering on the timeline should update the debugger.

Comment 7

[Dorel Luca [:dluca]]

Backed out changeset 1416218ae397 (bug 1580334) for Devtools failure on Debugger. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267774407&repo=autoland&lineNumber=9350

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1416218ae3977a77edfd65551653d953ff0dd629

Backout:
https://hg.mozilla.org/integration/autoland/rev/7a6e4de487922e968ca92188ef7b5ad374c6ec5a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eacd9c4b5ef
Hovering on the timeline should update the debugger.

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8eacd9c4b5ef