1580348 - Port |Bug 906190 - Persist "disable protection" option for Mixed Content Blocker in child tabs| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, task)

Description

[Ian Neal]

Port the following:

• Bug 906190 - Persist "disable protection" option for Mixed Content Blocker in child tabs
• Bug 1038604 - Rename disableMCB to allowMixedContent

Comment 1

[Ian Neal]

Attachment: Mixed content

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: More/less prompts on mixed content
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9091945 [details] [diff] [review]
Mixed content

"Open Link in new tab" in mail mail preview using middle mouse button:

Timestamp: 10/20/2019, 2:02:47 AM
Error: ReferenceError: gBrowser is not defined
Source File: chrome://communicator/content/contentAreaClick.js
Line: 118

Didn't test if getBrowser()would fix it but probably.

Comment 3

[Ian Neal]

Attachment: Mixed content v1.1

As suggested getBrowser() does fix the issue.

Comment 4

[Frank-Rainer Grahl (:frg)]

IanN, do you have a test site? So far with or without the patch I see no difference. Red bar always shows if I navigate to a new tab.

Comment 5

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9102819 [details] [diff] [review]
Mixed content v1.1

Everthing checks out even with an example so r/a+ We can fix any non working stuff in a follow-up if needed.

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: 99999.patch

Adding the checks in the patch fixes the net:error issues. Avoids the exceptions and lets the code run till it disables the button in

// For neterrors do not show the What Should I Do and Technical Details
// sections.
if (document.documentURI.startsWith("about:neterror")) {

Just entering about:certerror still shows it but this should be the only case left and not very relevant.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c7d09e547b0f
Port |Bug 906190 - Persist "disable protection" option for Mixed Content Blocker in child tabs| to SeaMonkey. r=frg DONTBUILD

Comment 8

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/f029948637f26d8bb35a2f92ccf60e017a137334

Comment 9

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/e681031e0399a5879da82626852dd7863780ca90