Closed Bug 1580348 Opened 1 year ago Closed 1 year ago

Port |Bug 906190 - Persist "disable protection" option for Mixed Content Blocker in child tabs| to SeaMonkey

Categories

(SeaMonkey :: General, task)

task
Not set
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

RESOLVED FIXED
seamonkey2.69
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file, 2 obsolete files)

Port the following:

  • Bug 906190 - Persist "disable protection" option for Mixed Content Blocker in child tabs
  • Bug 1038604 - Rename disableMCB to allowMixedContent
Attached patch Mixed content (obsolete) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: More/less prompts on mixed content
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Attachment #9091945 - Flags: review?(frgrahl)
Attachment #9091945 - Flags: approval-comm-release?
Attachment #9091945 - Flags: approval-comm-esr60?
Comment on attachment 9091945 [details] [diff] [review]
Mixed content

"Open Link in new tab" in mail mail preview using middle mouse button:

Timestamp: 10/20/2019, 2:02:47 AM
Error: ReferenceError: gBrowser is not defined
Source File: chrome://communicator/content/contentAreaClick.js
Line: 118

Didn't test if getBrowser()would fix it but probably.
Attachment #9091945 - Flags: review?(frgrahl)
Attachment #9091945 - Flags: feedback+
Attachment #9091945 - Flags: approval-comm-release?
Attachment #9091945 - Flags: approval-comm-esr60?

As suggested getBrowser() does fix the issue.

Attachment #9091945 - Attachment is obsolete: true
Attachment #9102819 - Flags: review?(frgrahl)
Attachment #9102819 - Flags: approval-comm-release?
Attachment #9102819 - Flags: approval-comm-esr60?

IanN, do you have a test site? So far with or without the patch I see no difference. Red bar always shows if I navigate to a new tab.

Flags: needinfo?(iann_bugzilla)
Comment on attachment 9102819 [details] [diff] [review]
Mixed content v1.1

Everthing checks out even with an example so r/a+ We can fix any non working stuff in a follow-up if needed.
Attachment #9102819 - Flags: review?(frgrahl)
Attachment #9102819 - Flags: review+
Attachment #9102819 - Flags: approval-comm-release?
Attachment #9102819 - Flags: approval-comm-release+
Attachment #9102819 - Flags: approval-comm-esr60?
Attachment #9102819 - Flags: approval-comm-esr60+
Attached patch 99999.patch (obsolete) — Splinter Review

Adding the checks in the patch fixes the net:error issues. Avoids the exceptions and lets the code run till it disables the button in

// For neterrors do not show the What Should I Do and Technical Details
// sections.
if (document.documentURI.startsWith("about:neterror")) {

Just entering about:certerror still shows it but this should be the only case left and not very relevant.

Attachment #9107732 - Attachment filename: 99999.patch → patch for wrong bug
Attachment #9107732 - Attachment is obsolete: true

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c7d09e547b0f
Port |Bug 906190 - Persist "disable protection" option for Mixed Content Blocker in child tabs| to SeaMonkey. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Flags: needinfo?(iann_bugzilla)
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.