Port |Bug 906190 - Persist "disable protection" option for Mixed Content Blocker in child tabs| to SeaMonkey
Categories
(SeaMonkey :: General, task)
Tracking
(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.1)
Attachments
(1 file, 2 obsolete files)
9.08 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Port the following:
- Bug 906190 - Persist "disable protection" option for Mixed Content Blocker in child tabs
- Bug 1038604 - Rename disableMCB to allowMixedContent
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: More/less prompts on mixed content
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Comment 2•5 years ago
|
||
Comment on attachment 9091945 [details] [diff] [review] Mixed content "Open Link in new tab" in mail mail preview using middle mouse button: Timestamp: 10/20/2019, 2:02:47 AM Error: ReferenceError: gBrowser is not defined Source File: chrome://communicator/content/contentAreaClick.js Line: 118 Didn't test if getBrowser()would fix it but probably.
As suggested getBrowser() does fix the issue.
Comment 4•5 years ago
|
||
IanN, do you have a test site? So far with or without the patch I see no difference. Red bar always shows if I navigate to a new tab.
Comment 5•4 years ago
|
||
Comment on attachment 9102819 [details] [diff] [review] Mixed content v1.1 Everthing checks out even with an example so r/a+ We can fix any non working stuff in a follow-up if needed.
Comment 6•4 years ago
|
||
Adding the checks in the patch fixes the net:error issues. Avoids the exceptions and lets the code run till it disables the button in
// For neterrors do not show the What Should I Do and Technical Details
// sections.
if (document.documentURI.startsWith("about:neterror")) {
Just entering about:certerror still shows it but this should be the only case left and not very relevant.
Updated•4 years ago
|
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c7d09e547b0f
Port |Bug 906190 - Persist "disable protection" option for Mixed Content Blocker in child tabs| to SeaMonkey. r=frg DONTBUILD
Comment 8•4 years ago
|
||
Comment 9•4 years ago
|
||
Description
•