Closed Bug 1580356 Opened 2 months ago Closed 2 months ago

Remove Fennec build system support and source code

Categories

(Firefox Build System :: Android Studio and Gradle Integration, task)

task
Not set

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

(Blocks 6 open bugs)

Details

Attachments

(3 files, 10 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

Bug 1570411 added a --without-fennec flag, but didn't do anything to act on that flag during the build. This ticket tracks doing some of that.

It's possible we just want to delete all this code rather than guarding it, since it's now the 71 cycle, but I started down this path so I'll continue for a while.

GeckoView builds produce artifact for download by Mozilla's regular
consumer audience. It's not clear what, if anything, depends on this
download information, but this is a reasonable way to find out!

This does a few things when --without-fennec:

  1. stops producing (and consuming) FennecJNI* JNI wrappers
  2. removes the :app and :thirdparty Gradle projects
  3. removes relevant pieces of the Gradle target configuration
  4. updates lints

Depends on D46535

Try builds:

artifact, --without-fennec: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3f59dfd6d041ecc636d6035f6d53b28911e8c1c
full, --without-fennec: https://treeherder.mozilla.org/#/jobs?repo=try&revision=18862015914957b5bbd19e9927a50148509359ae

--with-fennec is busted in automation: I'll need to update the Gradle dependencies. Or get rid of with{out}GeckoBinaries, which isn't really needed after Bug 1550146.

Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #9094056 - Attachment description: Bug 1580356 - Respect --without-fennec during build. r?snorp!,#build! → Bug 1580356 - Part 1: Remove Fennec from the build. r?snorp!,#build!
Attachment #9094057 - Attachment is obsolete: true

Per @snorp's suggestion, I made this tear out (most of) Fennec. I will file some follow-ups as I have energy.

To my reviewers, all of the "TO FOLD" pieces will be collapsed into the main commit, which will land all at once.

To @snorp: I suggest downloading the patch and looking at the diffstat locally. Good luck making sense of anything in Phab :(

Summary: Respect --without-fennec during build → Remove Fennec build system support and source code

It's not clear to me what "signing" a Maven artifact means: doubtless
there's a way to include GPG signatures. But we don't do it at this
time, and these tasks require Fennec APKs, so we remove them.

Depends on D47702

Attachment #9094056 - Attachment description: Bug 1580356 - Part 1: Remove Fennec from the build. r?snorp!,#build! → Bug 1580356 - Remove Fennec (Firefox for Android). r?snorp!,r?mshal!
Attachment #9097521 - Attachment is obsolete: true
Attachment #9097522 - Attachment is obsolete: true
Attachment #9097523 - Attachment is obsolete: true
Attachment #9097524 - Attachment is obsolete: true
Attachment #9097525 - Attachment is obsolete: true
Attachment #9097526 - Attachment is obsolete: true
Attachment #9098334 - Attachment is obsolete: true
Attachment #9098335 - Attachment is obsolete: true
Attachment #9098336 - Attachment is obsolete: true
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f7cf55ea869
Pre: Allow no download information in informulate.py. r=mshal
https://hg.mozilla.org/integration/autoland/rev/2009acbb8bfa
Pre: Don't collect package metrics. r=mshal
https://hg.mozilla.org/integration/autoland/rev/1ffe2e3d6e19
Remove Fennec (Firefox for Android). r=snorp,mshal

Sheriffs: hopefully this sticks -- it's a huge patch, I really don't want to rebase it, etc. Try was basically happy: https://treeherder.mozilla.org/#/jobs?repo=try&revision=af5eb485915d4bc2a29f21e9f4e5ae0d8b2c0632.

This shouldn't have touched l10n.toml. See conversation in
https://bugzilla.mozilla.org/show_bug.cgi?id=1582218#c1

I'm going to see if sheriffs can land a follow-up reverting this specific change before it merges to m-c
https://hg.mozilla.org/integration/autoland/diff/1ffe2e3d6e19a351575ac986c43155ed8e8d90bc/mobile/android/locales/l10n.toml

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/05318e974f73
Add back l10n path definition for mobile/android/base. a=bustage-fix

(In reply to Francesco Lodolo [:flod] from comment #20)

This shouldn't have touched l10n.toml. See conversation in
https://bugzilla.mozilla.org/show_bug.cgi?id=1582218#c1

I'm going to see if sheriffs can land a follow-up reverting this specific change before it merges to m-c
https://hg.mozilla.org/integration/autoland/diff/1ffe2e3d6e19a351575ac986c43155ed8e8d90bc/mobile/android/locales/l10n.toml

Sorry, flod: you are right that there was a discussion (in Phab?) but I though I had restricted myself to changes that weren't relevant across trees. Sorry that I didn't get an l10n peer's review, and thanks for filing the follow-up very quickly.

Regressions: 1586748
You need to log in before you can comment on or make changes to this bug.