Closed Bug 1580395 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18981 - Revert "Switch InterpolableLength implementation from length array to expression"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18981 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18981
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

Revert "Switch InterpolableLength implementation from length array to expression"

This reverts commit dd1318d7b1537af982313d51433e00fc02421225.

Reason for revert: caused performance regression crbug.com/1002177

Original change's description:

Switch InterpolableLength implementation from length array to expression

This patch changes the internal implementation of InterpolableLength
from CSSLengthArray to the following:

  • A CSSNumericLiteralValue to keep it simple when it's a simple value
  • A CSSMathExpressionNode to make it general when the underlying length
    involves calculation and math functions

In this way, we can interpolate when the length cannot be represented
as a CSSLengthArray (i.e., when comparison functions min/max are
involved).

Bug: 991672
Change-Id: Ib83fc0a07d0eb1d03a2465ac9df5282f963b935b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777025
Commit-Queue: Xiaocheng Hu \<xiaochengh@chromium.org>
Reviewed-by: Alan Cutter \<alancutter@chromium.org>
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694443}

TBR=alancutter@chromium.org,eae@chromium.org,xiaochengh@chromium.org,futhark@chromium.org

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 991672
Change-Id: I4467c0b4c8202dbc38ac5152620666caa38648e0

Reviewed-on: https://chromium-review.googlesource.com/1797822
WPT-Export-Revision: 6a3154053bb3a5e0f08699eaed698c9ecf5e7d55

PR 18981 applied with additional changes from upstream: 23209b4b1aecd29a86d33e1ac5145219983099fa
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/450456a18183 [wpt PR 18981] - Revert "Switch InterpolableLength implementation from length array to expression", a=testonly
Result changes from PR not available.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.