1580398 - Clarify and refactor how and when FxA keys are fetched

Status: RESOLVED DUPLICATE of bug 1647588

(Cloud Services :: Server: Firefox Accounts, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

There's some confusion when we need to fetchKeys():

• sync needs the keys, but explicitly calls this._fxaService.keys.getKeys() when it needs them.

• FxAccountsWebChannel explictly calls this._fxAccounts.keys.getKeys() whenever the password changes, and a comment indicates this is because they are needed for device registration (specifically, for send tab command registration)

But they can't both be correct - we want to register a device as soon as a login happens, so either we must already have keys when sync explicitly asks for them, or we don't actually need them at device registration time. We should work out who is lying :)

Comment 1

[Ryan Kelly [:rfkelly]]

or we don't actually need them at device registration time

We can register basic device record without them, but we definitely do need the keys in order to register support for send-tab. So...maybe sync is the one doing it wrong here, and is doing it as a kind of 'ensure we have the keys just in case, even though we probably do already' kind of thing?

Comment 2

[Ryan Kelly [:rfkelly]]

I suspect I can going to resolve this as part of a key-derivation refactor over in Bug 1647588, linking it for context.

Comment 3

[Wil Clouser [:clouserw]]

@mark - Is there more to do here?

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Most of the work was done in bug 1647588 and any other identified work is now stale.