Closed Bug 1580427 Opened 5 years ago Closed 5 years ago

Unused forward declarations of nsIDOMWindowProxy

Categories

(Core :: DOM: Bindings (WebIDL), defect, P1)

Product:
Core
Component:
DOM: Bindings (WebIDL)
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

Bug 1580427 - Fix the nativeType for WindowProxy.
47 bytes, text/x-phabricator-request
Details | Review

Three files, MozDocumentObserverBinding.h, MozFrameLoaderOwnerBinding.h and SessionStoreUtilsBinding.h, forward declare a class nsIDOMWindowProxy, but there are no other references to nsIDOMWindowProxy, so presumably those are not actually needed.

Assignee: nobody → continuation

The use of the bogus nativeType for WindowProxy means that trying to
actually use it will generate compile errors.

Attachment #9092050 - Attachment description: Bug 1580427 - Don't generate forward decls for nsIDOMWindowProxy because that class doesn't exist. → Bug 1580427 - Fix the nativeType for WindowProxy.
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/048ed2490381
Fix the nativeType for WindowProxy. r=bzbarsky
Priority: -- → P1

https://hg.mozilla.org/mozilla-central/rev/048ed2490381

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: