Closed
Bug 1580440
Opened 5 years ago
Closed 5 years ago
Simplify more code around `nsPlainTextSerializer` and the current line it operates on
Categories
(Core :: DOM: Serializers, enhancement)
Core
DOM: Serializers
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)
Details
Attachments
(5 files)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
It became superfluous after CurrentLineContent::mWidth could be
removed.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D45519
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D45520
|
|
Assignee | |
Comment 4•5 years ago
|
||
Previously, this could be mistaken for the width of the character
sequence.
Depends on D45521
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D45522
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → mbrodesser
|
||
Updated•5 years ago
|
Attachment #9092065 -
Attachment description: Bug 1580440: part 4) Rename `Indentation::mWidth` to `Indentation::mNumberOfCharacters. r=hsivonen → Bug 1580440: part 4) Rename `Indentation::mWidth` to `Indentation::mLength`. r=hsivonen
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e86c260a7f7 part 1) Replace `CurrentLineContent` with its only member. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/912220c34234 part 2) Add enum class for header strategy. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/dd469ecd5a06 part 3) Slightly simplify `EndLine`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/e90a48418e7a part 4) Rename `Indentation::mWidth` to `Indentation::mLength`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/12322ddc2a45 part 5) Execute finding upper bound for line wrapping only when needed. r=hsivonen
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2e86c260a7f7
https://hg.mozilla.org/mozilla-central/rev/912220c34234
https://hg.mozilla.org/mozilla-central/rev/dd469ecd5a06
https://hg.mozilla.org/mozilla-central/rev/e90a48418e7a
https://hg.mozilla.org/mozilla-central/rev/12322ddc2a45
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•