Closed Bug 1580468 Opened 1 year ago Closed 1 year ago

[Translate.Next] Align nomenclature of Fluent frontend code with @fluent/syntax

Categories

(Webtools :: Pontoon, task, P3)

task

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Assigned: mathjazz)

References

()

Details

There's a couple of renames that I'd like to suggest around the TN Fluent code. Being more aligned with nomenclature inside @fluent/syntax would make the code easier to understand from a Fluent perspective.

flattenElements -> flattenPatternElements, or maybe even flattenPattern ?
FluentElement -> FluentPatternElement
FluentValue -> FluentPattern

... though, generally, is it possible to not have the Fluent prefix in types.js?

FluentMessage might be a FluentEntry, if it's covering Terms, too.

Basically, anything that exists in https://github.com/projectfluent/fluent.js/blob/master/fluent-syntax/src/ast.js should also be named in the way that it's named there.

Priority: -- → P3
Summary: Align nomenclature of Fluent frontend code with @fluent/syntax → [Translate.Next] Align nomenclature of Fluent frontend code with @fluent/syntax
Assignee: nobody → m
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.