1580469 - Add mochitests for capturing a profile with the popup

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P2)

Description

[Greg Tatum [:gregtatum]]

We need mochitests that exercise the the popup, and capture a profile.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1581975 - Factor out the getSymbolsTable browser code from client code; r?julienw

The popup's shortcuts use a different codepath than the popup's buttons.
When using the buttons, the profile was not being captured as a gzipped
profile, and it was using the DevTools' mechanism for getting the symbol
tables. This patch makes the getSymbolTables mechanism configuring in the
recording panel's client.

In addition, browser code made its way into the client. This patch moves
the browser code to all be in browser.js to match the original code
organization for the panel, which was trying to keep browser APIs
out of the React components and Redux store.

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1580469 - Create end to end profile capture tests; r?julienw

This patch creates the first full mochitests that excercise the profiler
popup's mechanisms of capturing profiles. The tests try to use user-focused
mechanisms such as keyboard shortcuts and clicking buttons to fully
capture a profile.

Depends on D45529

Comment 3

[Phabricator Automation]

Comment on attachment 9092073 [details]
Bug 1581975 - Factor out the getSymbolsTable browser code from client code; r?julienw

Revision D45529 was moved to bug 1581975. Setting attachment 9092073 [details] to obsolete.

Comment 4

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3690d1ae314e6b511ed42b049362585883336075

Comment 5

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c32ac91355bd56c7a703b606979b0f575adc7543

Comment 6

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d701b5e4e2c9a9224997592743714781d91135d9

Comment 7

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=10ed82277f4d7c4c6a768a4dac21434b42f9f8b5

Comment 8

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8f4baa4c079e919e3e4708836ca27e3a495c963

Comment 9

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2c5783461d8d30c327e2e056ee011d52bdfa5f4

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f44e632769d7
Create end to end profile capture tests; r=julienw

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/594e6c588af8
Create end to end profile capture tests; r=julienw

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3744d80c98e6
Backed out 2 changesets (bug 1580469, bug 1581975) for devtools failure at browser/browser_aboutdebugging_serviceworker_timeout.js

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/594e6c588af8