1580487 - Stop preprocessing global.css

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P5)

Description

[Brian Grinstead [:bgrins]]

All platforms:

• global.inc.css could be @imported
• notification-popup.inc.css could be separately @imported or the one rule in there could gett folded into global.inc.css

OSX:

• shared.inc defines could turn into CSS variables, and references to them updated in all the files that include it: https://searchfox.org/mozilla-central/search?q=shared.inc&path=

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1580487 - Eliminate the remaining %includes in global.css and the shared toolkit stylesheets. r?Dao!

Depends on D140275

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1580487 - Clean up orphaned windows alert.css. r?Dao!

• Bug 1754271 Moved these rules to the shared alert.css, and removed the manifest entry but neglected to actually rm the file

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1580487 - Rename the shared menulist.css for consistency. r?Dao!

Depends on D141546

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/048435b47929
Clean up orphaned windows alert.css. r=dao
https://hg.mozilla.org/integration/autoland/rev/bebaec8c027b
Rename the shared menulist.css for consistency. r=dao
https://hg.mozilla.org/integration/autoland/rev/8bc5225bd59d
Eliminate the remaining %includes in global.css and the shared toolkit stylesheets. r=dao

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/048435b47929
https://hg.mozilla.org/mozilla-central/rev/bebaec8c027b
https://hg.mozilla.org/mozilla-central/rev/8bc5225bd59d