Closed
Bug 1580487
Opened 5 years ago
Closed 2 years ago
Stop preprocessing global.css
Categories
(Toolkit :: Themes, task, P5)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: bgrins, Assigned: sfoster)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-2022-mr1-css-linting])
Attachments
(3 files)
All platforms:
- global.inc.css could be @imported
- notification-popup.inc.css could be separately @imported or the one rule in there could gett folded into global.inc.css
OSX:
- shared.inc defines could turn into CSS variables, and references to them updated in all the files that include it: https://searchfox.org/mozilla-central/search?q=shared.inc&path=
|
||
Updated•5 years ago
|
Priority: -- → P5
|
Assignee | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D140275
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
- Bug 1754271 Moved these rules to the shared alert.css, and removed the manifest entry but neglected to actually rm the file
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D141546
|
||
Updated•2 years ago
|
Attachment #9266395 -
Attachment description: WIP: Bug 1580487 - (WIP) use @import rather than %include for shared toolkit stylesheets → Bug 1580487 - Eliminate the remaining %includes in global.css and the shared toolkit stylesheets. r?Dao!
|
|
Assignee | |
Updated•2 years ago
|
Keywords: leave-open
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/048435b47929 Clean up orphaned windows alert.css. r=dao https://hg.mozilla.org/integration/autoland/rev/bebaec8c027b Rename the shared menulist.css for consistency. r=dao https://hg.mozilla.org/integration/autoland/rev/8bc5225bd59d Eliminate the remaining %includes in global.css and the shared toolkit stylesheets. r=dao
|
|
Assignee | |
Updated•2 years ago
|
Keywords: leave-open
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/048435b47929
https://hg.mozilla.org/mozilla-central/rev/bebaec8c027b
https://hg.mozilla.org/mozilla-central/rev/8bc5225bd59d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•