Closed Bug 1580504 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18997 - Fix two css-grid tests that were broken by Ahem web font transition.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18997 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18997
Details from upstream follow.

Luke Zielinski <lpz@chromium.org> wrote:

Fix two css-grid tests that were broken by Ahem web font transition.

These tests were broken because the checkLayout method implicitly calls done() itself, which causes only the first subtest to run.

But we can call checkLayout(.., callDone=false) and call done() ourselves instead.

PR 18997 applied with additional changes from upstream: c66230eebbea3bce8c086572869eb0835fb183b5
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 2 tests and 4 subtests
OK     : 2
PASS   : 4
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1716c85e698b
[wpt PR 18997] - Fix two css-grid tests that were broken by Ahem web font transition., a=testonly

https://hg.mozilla.org/mozilla-central/rev/1716c85e698b

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.