1580512 - input[type="number"] in prefs not tall enough

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The border around the input[type="number"] isn't outside the spinbuttons.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1580512-input-type-number.patch

Unfortunately we need different paddings per platform.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2019-09-11 09-04-49.png

Linux on HiDPI monitor

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9092104 [details] [diff] [review]
1580512-input-type-number.patch

Review of attachment 9092104 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good on macOS but on Linux it should be 6px as well.
I don't know if it's due to the fact that I'm using a HiDPI monitor with large font.

Anyway, after this quick fix it's a r+ for me.
I don't have the ability to check it on Windows tho.

Thanks for taking care of this.

::: mail/themes/linux/mail/preferences/preferences.css
@@ +24,5 @@
>    margin-bottom: 11px;
>  }
>  
> +html|input[type="number"] {
> +  padding: 5px 1px;

This should be 6px as well (see screenshot)

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1580512-input-type-number.patch

Yes, 6px looks better.

Comment 5

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2019-09-11 12-19-59.png

Heads up, the problem with the field is not limited to the preferences panel.

Comment 6

[Richard Marti (:Paenglab)]

Found bug 1577602 which seems to be the reason for this issue. I'm looking for a different approach.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1580512-input-type-number.patch

This reverts the change on the ::-moz-number-spin-box from bug 1577602.

Comment 8

[Alessandro Castellani [:aleca]]

Comment on attachment 9092186 [details] [diff] [review]
1580512-input-type-number.patch

Review of attachment 9092186 [details] [diff] [review]:
-----------------------------------------------------------------

This perfectly fixes the problem everywhere. 
Great work!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7d960e3a15ab
Revert bug 1577602 on the ::-moz-number-spin-box to make the input[type="number"] box taller. r=aleca