Closed Bug 158054 Opened 18 years ago Closed 17 years ago

unix installer crashes if Title not defined in config.ini

Categories

(SeaMonkey :: Installer, defect, critical)

All
Linux
defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ajschult784, Assigned: dveditz)

Details

(Whiteboard: need some checkin love)

Attachments

(1 file)

if General/Title is not defnied in config.ini, the installer attempts to fall
back to "Default Title" from installer.ini, but fails:

  strcpy(gCtx->opt->mTitle, gCtx->Res("DEFAULT_TITLE"));

mTitle is NULL.  should use malloc before strcpy or just strdup.
QA Contact: bugzilla → ktrina
Attached patch trivial patchSplinter Review
strdup instead of strcpy
Attachment #106619 - Flags: review?(sgehani)
Comment on attachment 106619 [details] [diff] [review]
trivial patch

r=sgehani
Attachment #106619 - Flags: review?(sgehani) → review+
Attachment #106619 - Flags: superreview?(dveditz)
Attachment #106619 - Flags: superreview?(dveditz) → superreview+
thanks for the reviews
dveditz, could you check this in?
Keywords: patch
Whiteboard: need some checkin love
Comment on attachment 106619 [details] [diff] [review]
trivial patch

this fixes a crash, although Mozilla installer (as packaged) does not hit this
piece of code.

No risk because the current code will always crash if it is used.
Attachment #106619 - Flags: approval1.4b?
Comment on attachment 106619 [details] [diff] [review]
trivial patch

a=sspitzer
Attachment #106619 - Flags: approval1.4b? → approval1.4b+
Checking in nsXInstaller.cpp;
/cvsroot/mozilla/xpinstall/wizard/unix/src2/nsXInstaller.cpp,v  <-- 
nsXInstaller.cpp
new revision: 1.27; previous revision: 1.26
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
verified code fix
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.