Closed
Bug 1580597
Opened 5 years ago
Closed 5 years ago
Set correct timestamps for WebRTCMediaDataEncoderCodec.
Categories
(Core :: Audio/Video, defect, P2)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: jhlin, Assigned: jhlin)
References
Details
Attachments
(2 files)
AppleVTEncoder
doesn't set the timestamp value in VideoData
and AndroidDataEncoder
should send timestamp in microseconds to CodecProxy
.
Priority: -- → P2
Assignee | ||
Comment 1•5 years ago
|
||
Bug 1568101/D40532 captures the input timestamp and uses it in the resolve
function. However, there could be multiple encoded frames returned (e.g.,
for Drain()), and all of them will get the same captured timestamp. Read
back the timestamp from encoded data makes sure every frame gets the right
value. Also convert it for EncodedImage::_timeStamp uses different unit.
Depends on D45773
Assignee | ||
Comment 2•5 years ago
|
||
Also remove the definition of unused struct for tracking of input timestamp.
Depends on D45774
Pushed by jolin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cbcba8e0c801 p1: pass timestamp values correctly. r=jya https://hg.mozilla.org/integration/autoland/rev/ce274dd6db3a p2: set timestamp and duration of the encoded frame. r=jya
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cbcba8e0c801
https://hg.mozilla.org/mozilla-central/rev/ce274dd6db3a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•