Closed Bug 1580603 Opened 4 years ago Closed 4 years ago

Refactor document fullscreen stack to become top layer

Categories

(Core :: DOM: Core & HTML, task, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: ntim, Assigned: sefeng)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1580603 - Refactor Fullscreen stack to Top Layer stack r=xidorn,smaug
47 bytes, text/x-phabricator-request
Details | Review

This refactor would make implementing modal dialogs a lot easier.

FullscreenStackPop/FullscreenStackPush are fairly straightforward to change, the functions can just be renamed to be TopLayerPop/TopLayerPush, with the fullscreen state/viewport bits factored out in the individual callers. I think the FullscreenStackPop calls will need an extra check for the fullscreen state, but the same thing probably applies.

Assignee: nobody → sefeng
Priority: -- → P3
Attachment #9136166 - Attachment description: Bug 1580603 - Refactor Fullscreen stack to Top Layer stack r=ntim,smaug → Bug 1580603 - Refactor Fullscreen stack to Top Layer stack r=xidorn,smaug
Blocks: 1322939
Pushed by sefeng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dc7cd341a2a
Refactor Fullscreen stack to Top Layer stack r=smaug,xidorn

https://hg.mozilla.org/mozilla-central/rev/1dc7cd341a2a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Regressions: 1630541
No longer regressions: 1630541
You need to log in before you can comment on or make changes to this bug.