1580699 - With Fission enabled "WebDriver:SwitchToFrame" raises: SecurityError: Permission denied to access property "frameElement" on cross-origin object

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As noticed on bug 1580692 the WebDriver:SwitchToFrame command is broken under Fission. The following error gets raised:

JavaScript error: chrome://marionette/content/listener.js, line 1542: SecurityError: Permission denied to access property "frameElement" on cross-origin object

Here the source code:

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/testing/marionette/listener.js#1542

It means we cannot directly access frameElement here.

I assume this would need actors in each frame, and to do the comparison in the parent process?

Mike, if you could give a hint that would be great. Thanks!

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Yeesh, sorry for the delay getting back to this. My needinfo stack is too high. :(

So yes, with Fission enabled, you'll not be able to access properties like the frameElement on third-party iframes. I actually think that might be true even today without Fission - evaluating window.frames[1].frameElement from the console at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe throws the same exception.

What you might be able to do is get access to the BrowsingContext of the frame you're interested in, and then send a message to that BrowsingContext's parent. That parent should be able to access the frameElement by accessing .embedderElement on it, which should return the <iframe>, assuming that that DOM node exists in the process running that.

Comment 2

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 3

[Chris Peterson [:cpeterson]]

Tracking for Fission milestone M6 because we want to be able to run Marionette tests with Fission before enabling in Nightly.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like we have to replace outerWindowId with browsingContext.id first, before we can work on this bug.

Comment 5

[Chris Peterson [:cpeterson]]

Tracking WPT Fission bugs for Fission M6b (Q2)

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Note that the wdspec cross-origin tests for switchToFrame are the only tests I could find that exercise WebDriver/Marionette cross-origin behaviour.

Comment 7

[Neha Kochar [:neha]]

This is definitely Fission beta blocking.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

SwitchToFrame has been slightly refactored. So the affecting line here is:

https://searchfox.org/mozilla-central/rev/ab81b8552f4aa9696a2524f97fdfeb59d4dc31c1/testing/marionette/listener.js#1557

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This will be fixed with bug 1654628 when the command gets executed with the JSWindowActor implementation. But even then it will be put behind the preference marionette.actors.enabled for the time being. Once the implementation is stable, it will be enabled by default.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The remaining warning is all related to page navigation and should be fixed by bug 1612831.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So to get rid of this it finally needs bug 1660168, which is enabling the usage of the JSWindowActor by default for Fission builds.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the patch on bug 1660168 the test is no longer failing.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Now with turned on actor usage in Marionette for Fission this is no longer a problem. As such marking as fixed.