1580719 - remove grid usage from comm/mail/components/compose/content/dialogs/edImage.inc.xul

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, task)

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1580719_remove-grid-edImage-inc-xul.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9092562 [details] [diff] [review]
Bug-1580719_remove-grid-edImage-inc-xul.patch

Review of attachment 9092562 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/compose/content/dialogs/edImage.inc.xul
@@ +43,5 @@
> +                       control="titleInput"
> +                       accesskey="&title.accessKey;"
> +                       value="&title.label;"
> +                       tooltiptext="&title.tooltip;"
> +                       for="titleInput"/>

this is a xul:label, it does't have for, so remove that

@@ +57,5 @@
> +              </hbox>
> +            </vbox>
> +            <vbox>
> +              <textbox flex="1"
> +                       id="titleInput"

move id first here, and in the other case

@@ +133,5 @@
> +          <vbox flex="1">
> +            <menulist id="widthUnitsMenulist"
> +                      oncommand="doDimensionEnabling();" />
> +            <menulist id="heightUnitsMenulist"
> +                        oncommand="doDimensionEnabling();" />

alignment off by a space or two

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1580719_remove-grid-edImage-inc-xul.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3fbaa02a4fce
remove grid usage from edImage.inc.xul. r=mkmelin