1580726 - revisit manifest conditions for reftest

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement, P3)

Description

[Edwin Takahashi (:egao | infrequent contributor)]

Summary

There are many manifest conditions for reftest specified in the manifest.jsm file:
https://searchfox.org/mozilla-central/source/layout/tools/reftest/manifest.jsm#398-576

Some manifest conditions such as skiaContent, azureSkia and azureCairo represent slightly different versions of some condition.

While these may have served a use in the past, it's likely that some of the conditions here no longer serve any useful purpose, but the reftest manifests still carry them since no one has revisited the conditions.

Data

An example push with skiaContent removed from dom/html/reftests/autofocus/reftest.list run on all Windows platforms shows the manifest condition fuzzy-if(skiaContent) serves no actual use.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

When removing graphics-related reftest conditions, please ensure you get a review from somebody on the graphics team. Even though conditions may not be used at the moment, they may become relevant again in the future, or may be relevant in some tier-2 or specific configurations when running locally. Having spurious failures appear when running locally is just as undesirable as having extraneous conditions lying around.

/cc lsalzman,jrmuizel as FYI

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

this has been cleaned up a lot in the last 6 months.