Closed Bug 1580755 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19002 - [LayoutNG] Fix incorrect rounding in ShapingLineBreaker

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19002 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19002
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[LayoutNG] Fix incorrect rounding in ShapingLineBreaker

This patch fixes the rounding the end position to the same
direction as the rounding the start position. Before this
change, the end position was rounded to the line-end
direction. This may have resulted in slightly larger
available space than the given one.

Such an error can cause a large visual differences, because
|NGLineBreaker| determines the overflow by comparing the
result width to the available width, and if overflow occurs,
it assumes that it cannot break the result further.

This patch also adds |ShapingLineBreaker::Result::is_overflow|
so that |ShapingLineBreaker| can communicate its overflow
status to the caller.

Bug: 1002442
Change-Id: Iebee80117c9930eade029c45c561236b8916981a

Reviewed-on: https://chromium-review.googlesource.com/1797954
WPT-Export-Revision: c745eb0661a2ce142af493d52dc95d82c25f7d88

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52099744d468
[wpt PR 19002] - [LayoutNG] Fix incorrect rounding in ShapingLineBreaker, a=testonly

https://hg.mozilla.org/mozilla-central/rev/52099744d468

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.