Closed Bug 1580771 Opened 1 year ago Closed 4 months ago

Perma fail Fission dom/security/test/mixedcontentblocker/test_main.html | object did not follow block_active_content pref

Categories

(Core :: DOM: Security, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Fission Milestone M4.1

People

(Reporter: intermittent-bug-filer, Assigned: apavel)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [domsecurity-intermittent])

Attachments

(1 file)

Filed by: archaeopteryx [at] coole-files.de
Parsed log: http://localhost:5000/logviewer.html#?job_id=266274971&repo=mozilla-central
Full log: https://queue.taskcluster.net/v1/task/T3hp8VGkR9Cjl7gYFEaXoQ/runs/0/artifacts/public/logs/live_backing.log


[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - TEST-PASS | dom/security/test/mixedcontentblocker/test_main.html | imageJoinPicture did not follow block_active_content pref
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - TEST-PASS | dom/security/test/mixedcontentblocker/test_main.html | UniqueID for the last request matches
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - TEST-PASS | dom/security/test/mixedcontentblocker/test_main.html | imageLeavePicture did not follow upgrade_display_content pref
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - Buffered messages finished
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - TEST-UNEXPECTED-FAIL | dom/security/test/mixedcontentblocker/test_main.html | object did not follow block_active_content pref
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - receiveMessage@dom/security/test/mixedcontentblocker/test_main.html:121:11
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - EventListener.handleEventstartTest/<@dom/security/test/mixedcontentblocker/test_main.html:217:14
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - changePrefs/<@dom/security/test/mixedcontentblocker/test_main.html:45:7
[task 2019-09-12T10:44:19.835Z] 10:44:19 INFO - Async
changePrefs@dom/security/test/mixedcontentblocker/test_main.html:40:19
[task 2019-09-12T10:44:19.835Z] 10:44:19 INFO - startTest@dom/security/test/mixedcontentblocker/test_main.html:215:16
[task 2019-09-12T10:44:19.835Z] 10:44:19 INFO - onload@dom/security/test/mixedcontentblocker/test_main.html:1:1

Whiteboard: [domsecurity-intermittent]
Blocks: fission-mochitests
No longer blocks: fission
Summary: Intermittent dom/security/test/mixedcontentblocker/test_main.html | object did not follow block_active_content pref → Perma fail Fission dom/security/test/mixedcontentblocker/test_main.html | object did not follow block_active_content pref
Fission Milestone: --- → M4
Priority: P5 → P2

This is failing on fission since it was enabled here: https://hg.mozilla.org/mozilla-central/rev/0e84d46d732a396280f46e688c568838bf11e5d1#l2.11
Andreas, do you wanna fix the test to work on fission or can we disable it again?

Flags: needinfo?(afarre)

It fails with:
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - TEST-UNEXPECTED-FAIL | dom/security/test/mixedcontentblocker/test_main.html | object did not follow block_active_content pref
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - receiveMessage@dom/security/test/mixedcontentblocker/test_main.html:121:11
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - EventListener.handleEventstartTest/<@dom/security/test/mixedcontentblocker/test_main.html:217:14
[task 2019-09-12T10:44:19.834Z] 10:44:19 INFO - changePrefs/<@dom/security/test/mixedcontentblocker/test_main.html:45:7
[task 2019-09-12T10:44:19.835Z] 10:44:19 INFO - Async
changePrefs@dom/security/test/mixedcontentblocker/test_main.html:40:19
[task 2019-09-12T10:44:19.835Z] 10:44:19 INFO - startTest@dom/security/test/mixedcontentblocker/test_main.html:215:16
[task 2019-09-12T10:44:19.835Z] 10:44:19 INFO - onload@dom/security/test/mixedcontentblocker/test_main.html:1:1

Cosmin, can you add a fail-if=fission for this test as it is now failing for a different reason. Please also add a comment stating the cause "object did not follow block_active_content pref".

Flags: needinfo?(afarre) → needinfo?(csabou)
Flags: needinfo?(csabou)
Keywords: leave-open
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b6fb9c97216
Set test_main.html to always fail on fission r=neha
Whiteboard: [domsecurity-intermittent][stockwell disable-recommended] → [domsecurity-intermittent]
Whiteboard: [domsecurity-intermittent][stockwell disable-recommended] → [domsecurity-intermittent]

Roll unfixed test bugs from Fission Milestone M4 to M4.1

Fission Milestone: M4 → M4.1

Jonathan, I think this one will be fixed by Bug 1584157. I am assigning to you so we keep track of it.

Assignee: nobody → jkt
Status: NEW → ASSIGNED

Temporarily reassigning these DOM Security Fission bugs to ckerschb for re-triage.

Assignee: jonathan → ckerschb
Assignee: ckerschb → nobody
Status: ASSIGNED → NEW
Priority: P2 → P3

This Bug will most certainly be fixed by Bug 1631405. Will mark dependency so we can re-evaluate and close after Bug 1631405 has landed.

Depends on: 1631405
No longer depends on: 1584157

(In reply to Christoph Kerschbaumer [:ckerschb, back on June 8th] from comment #18)

This Bug will most certainly be fixed by Bug 1631405. Will mark dependency so we can re-evaluate and close after Bug 1631405 has landed.

Bug 1631405 was fixed last week. This test_main.html test was re-enabled for Fission by bug 1580565 (back in April):

https://hg.mozilla.org/mozilla-central/rev/9555dcc88ac9#l3.12

However this test is skip-if webrender (by bug 1402554 two years ago). We only test Fission with WebRender, so this test is effectively disabled for Fission.

https://searchfox.org/mozilla-central/rev/8ccea36c4fb09412609fb738c722830d7098602b/dom/security/test/mixedcontentblocker/mochitest.ini#23-26

Should we file a new bug to fix this test for WebRender? Eventually all desktop users will have WebRender and Fission, so we'll want this bug fixed by then.

The test also got disabled again in bug 1633941, and then enabled again in bug 1631405.

Anyway, we are running M-fis (as tier2) on non-webrender linux, so this is definitely passing with Fission now.

(In reply to Matt Woodrow (:mattwoodrow) from comment #20)

The test also got disabled again in bug 1633941, and then enabled again in bug 1631405.

Anyway, we are running M-fis (as tier2) on non-webrender linux, so this is definitely passing with Fission now.

In that case, I'll close this bug as fixed for Fission by bug 1631405.

This test is still skipped for WebRender (bug 1402554 since 2018). Bug 1402554 is still open.

https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/dom/security/test/mixedcontentblocker/mochitest.ini#23-26

[test_main.html]
skip-if =
  (toolkit == 'android') || webrender || (verify && !debug && (os == 'linux')) || # Android: TIMED_OUT; bug 1402554
  tsan # Times out / Memory consumption, bug 1612707
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Assignee: nobody → apavel
You need to log in before you can comment on or make changes to this bug.