1580792 - "Paste and Go" no longer searches for the clipboard term if strings are in the address bar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue1.gif

[Affected versions]:

• Firefox Beta 70.0b5 - Build ID: 20190909162732
• Firefox Nightly 71.0a1 - Build ID: 20190912094122

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have the latest Firefox Beta or Nightly installed.
• Have any text copied to clipboard.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Type a text string different from the one from prerequisites in the "Address Bar".
3. Right-click in the "Address Bar" and select the "Paste & Go" option.
4. Observe the behavior.

[Expected result]:

• A search is performed for the string copied to clipboard.

[Actual result]:

• The search is performed for the string typed at step 2.

[Regression Window]:

• Considering the fact that this issue is not reproducible on latest Firefox Release (69.0), using the "mozregression" tool I have managed to find the following regression:

Last good revision: 47e72c204ef61c34509e430c0976f4db680e384a
First bad revision: 580d975db59096011e93150a04856a15b9e8812d
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=47e72c204ef61c34509e430c0976f4db680e384a&tochange=580d975db59096011e93150a04856a15b9e8812d

From the pushlog, it seems that bug 1551598 caused this issue.

[Notes]:

• This issue is still reproducible even if you paste a URL in the "Address Bar" using the "Paste & Go" option
• Attached a screen recording of the issue.

Comment 1

[Dão Gottwald [::dao]]

I don't know what's going on here, haven't had time to take a closer look yet. Marco, Mike mentioned to me you might be interested in picking this up. Otherwise I'll investigate when I get a chance.

Comment 2

[Marco Bonardo [:mak]]

From a first analysis, apparently now we close the panel after the paste operation, closing the panel makes so that .selectedResult returns null.
What actually happens now is:
paste
handleCommand asks for .selectedResult, since it can find a selectedResult it calls pickResults
we close the panel

I think in the old world we were closing the popup sooner, and that ended up clearing the selection, so handleCommand didn't pick the selected result. I'm still looking where/how we were doing that though.

Comment 3

[Marco Bonardo [:mak]]

Ah the reason is simple, on right click (context menu) we used to close the urlbar panel.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1580792 - "Paste and Go" no longer searches for the clipboard term if strings are in the address bar. r=dao

Autocomplete used to close the urlbar panel when opening the contextual menu.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b3d42760974
"Paste and Go" no longer searches for the clipboard term if strings are in the address bar. r=dao

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1b3d42760974

Comment 8

[Marco Bonardo [:mak]]

Comment on attachment 9093838 [details]
Bug 1580792 - "Paste and Go" no longer searches for the clipboard term if strings are in the address bar. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Paste and go feature of the urlbar contextual menu doesn't work properly
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): it's a simple one-liner patch closing the urlbar panel
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9093838 [details]
Bug 1580792 - "Paste and Go" no longer searches for the clipboard term if strings are in the address bar. r=dao

Low risk, covered by tests, fixes a P1 70 regression, uplift approved for 70 beta 9, thanks.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/53a2c36a3610

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (71.0a1 Build ID - 20190923215658) and latest Firefox Beta (70.0b9 Build ID - 20190923154733) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, "Paste and Go" searches for the clipboard term, even if strings are already in the address bar.