1580822 - a11y focus lost when selecting the first one-off search button or the search settings button

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Dão Gottwald [:dao]]

It looks like at least the case of selecting the first one-off search button was broken before bug 1567384...

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1580822 - a11y focus lost when selecting the first one-off search button or the search settings button. r=mak,adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f12466ddbb8
a11y focus lost when selecting the first one-off search button or the search settings button. r=adw

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3f12466ddbb8

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9092396 [details]
Bug 1580822 - a11y focus lost when selecting the first one-off search button or the search settings button. r=mak,adw

Beta/Release Uplift Approval Request

• User impact if declined: see bug 1567384 comment 16
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: bug 1567384
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): just moving a few lines of code to the right place
• String changes made/needed:

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9092396 [details]
Bug 1580822 - a11y focus lost when selecting the first one-off search button or the search settings button. r=mak,adw

a11y fix for search, let's uplift for beta 7.

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/fa69c8d6b28b