1580847 - [wpt-sync] Sync PR 19025 - CSS: Serialize font shorthand with spaces around '/'

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Description

•

5 years ago

Sync web-platform-tests PR 19025 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19025
Details from upstream follow.

Eric Willigers <ericwilligers@chromium.org> wrote:

CSS: Serialize font shorthand with spaces around '/'

Each '/' is a CSS value should have a space before and after.
https://github.com/w3c/csswg-drafts/issues/4282

Omit 'normal' values from computed font serialization.

Change-Id: Iebbfe80ae0c7c3ebe0101b432c0d95a7d265154f

Reviewed-on: https://chromium-review.googlesource.com/1800894
WPT-Export-Revision: 8d756cac0c5ee7e818754a66704cb61a21790560

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

5 years ago

PR 19025 applied with additional changes from upstream: 892bd075ce48af308c4ec71aad93379b7dcc09dc

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

5 years ago

Component: web-platform-tests → Layout: Text and Fonts

Product: Testing → Core

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

5 years ago

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a38278e2f226801a5598bbdb69f268e9a6449e6

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 3

•

5 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e610dab1b496044b64a856ee24dde1408024f76

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 4

•

5 years ago

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=38d4bd1f862863829f82eedd69d635e968cb78ad

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 5

•

5 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=24d2eed801fc9f2b59be51851f69984cae932b9b

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 6

•

5 years ago

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=131e884b4babc4102cbccf074f517c93b827414f

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 7

•

5 years ago

Ran 5 tests and 677 subtests
OK     : 5
PASS   : 196[windows7-32-debug,windows7-32-opt], 197[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt]
FAIL   : 480[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt], 481[windows7-32-debug,windows7-32-opt]

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/css-fonts/parsing/font-valid.html
    e.style['font'] = "100 extra-condensed small-caps 20%/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "100 normal oblique small-caps 20%/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "100 normal small-caps condensed larger/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "100 oblique semi-condensed small-caps xx-large/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "100 small-caps normal semi-expanded calc(30% - 40px)/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "900 condensed small-caps normal calc(30% - 40px)/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "900 expanded normal small-caps xx-large/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "900 normal italic extra-condensed calc(30% - 40px)/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "900 normal normal small-caps xx-large/1.2 serif" should set the property value: FAIL
    e.style['font'] = "900 oblique small-caps normal 20%/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "900 small-caps larger/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "bold extra-condensed 20%/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "bold extra-expanded italic larger/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "bold italic small-caps ultra-condensed calc(30% - 40px)/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "bold normal 20%/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "bold normal normal ultra-condensed larger/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "bold oblique normal normal xx-large/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "bolder condensed normal calc(30% - 40px)/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "bolder italic normal small-caps larger/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "bolder normal expanded italic 20%/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "bolder normal normal calc(30% - 40px)/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "bolder small-caps oblique expanded xx-large/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "condensed 100 italic calc(30% - 40px)/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "condensed italic normal small-caps calc(30% - 40px)/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "condensed normal normal bolder calc(30% - 40px)/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "condensed normal small-caps 100 calc(30% - 40px)/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "condensed small-caps bold calc(30% - 40px)/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "condensed small-caps calc(30% - 40px)/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "expanded 100 xx-large/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "expanded bolder small-caps xx-large/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "expanded normal bolder italic xx-large/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "expanded normal oblique small-caps xx-large/1.2 serif" should set the property value: FAIL
    e.style['font'] = "expanded normal xx-large/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "expanded oblique small-caps normal xx-large/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "expanded small-caps normal italic xx-large/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "extra-condensed lighter normal small-caps 20%/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "extra-condensed normal normal small-caps 20%/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "extra-condensed normal small-caps oblique 20%/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "extra-condensed oblique lighter small-caps 20%/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "extra-condensed oblique normal normal 20%/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "extra-condensed small-caps oblique 900 20%/1.2 serif" should set the property value: FAIL
    e.style['font'] = "extra-expanded 900 normal larger/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "extra-expanded italic small-caps 900 larger/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "extra-expanded lighter small-caps normal larger/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "extra-expanded normal italic lighter larger/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "extra-expanded normal lighter small-caps larger/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "extra-expanded normal normal larger/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "extra-expanded small-caps normal 100 larger/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "italic 100 extra-expanded larger/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "italic 900 normal semi-expanded calc(30% - 40px)/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "italic bold larger/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "italic condensed 900 normal calc(30% - 40px)/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "italic condensed normal calc(30% - 40px)/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "italic extra-expanded small-caps larger/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "italic normal 100 condensed larger/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "italic normal extra-expanded 900 calc(30% - 40px)/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "italic normal normal calc(30% - 40px)/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "italic normal normal ultra-condensed larger/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "italic normal small-caps extra-condensed calc(30% - 40px)/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "italic small-caps 100 ultra-condensed calc(30% - 40px)/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "italic small-caps normal bold larger/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "lighter normal extra-expanded small-caps calc(30% - 40px)/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "lighter normal small-caps oblique xx-large/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "lighter small-caps extra-expanded larger/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "lighter small-caps normal italic 20%/1.2 serif" should set the property value: FAIL
    e.style['font'] = "normal 100 normal ultra-expanded 20%/1.2 serif" should set the property value: FAIL
    e.style['font'] = "normal 100 small-caps larger/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "normal 900 normal xx-large/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "normal 900 oblique calc(30% - 40px)/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "normal bold expanded small-caps xx-large/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "normal bold normal normal larger/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "normal bolder small-caps extra-condensed 20%/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "normal condensed normal small-caps calc(30% - 40px)/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "normal condensed small-caps italic calc(30% - 40px)/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "normal expanded bold normal xx-large/1.2 serif" should set the property value: FAIL
    e.style['font'] = "normal expanded oblique normal xx-large/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "normal extra-condensed normal oblique 20%/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "normal extra-condensed small-caps normal 20%/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "normal extra-expanded bolder oblique larger/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "normal extra-expanded italic small-caps larger/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "normal extra-expanded larger/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "normal italic 900 semi-condensed xx-large/1.2 serif" should set the property value: FAIL
    e.style['font'] = "normal italic normal 20%/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "normal italic normal extra-condensed xx-large/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "normal italic small-caps condensed 20%/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "normal italic ultra-expanded bold 20%/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "normal lighter condensed calc(30% - 40px)/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "normal lighter italic ultra-condensed xx-large/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "normal normal 100 larger/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "normal normal bolder small-caps 20%/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "normal normal extra-expanded italic xx-large/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "normal normal italic normal xx-large/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "normal normal lighter semi-condensed calc(30% - 40px)/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "normal normal normal bold calc(30% - 40px)/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "normal normal normal larger/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "normal normal normal small-caps 20%/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "normal normal oblique small-caps larger/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "normal normal small-caps 20%/1.2 serif" should set the property value: FAIL
    e.style['font'] = "normal normal small-caps condensed xx-large/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "normal normal small-caps normal calc(30% - 40px)/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "normal normal ultra-expanded small-caps larger/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "normal normal xx-large/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "normal oblique bolder calc(30% - 40px)/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "normal oblique normal normal calc(30% - 40px)/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "normal oblique semi-expanded larger/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "normal oblique small-caps larger/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "normal small-caps 900 normal xx-large/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "normal small-caps bold italic larger/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "normal small-caps calc(30% - 40px)/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "normal small-caps expanded oblique calc(30% - 40px)/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "normal small-caps italic lighter calc(30% - 40px)/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "normal small-caps normal bolder larger/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "normal small-caps normal oblique xx-large/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "normal small-caps oblique normal 20%/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "normal small-caps semi-expanded normal 20%/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "oblique 100 normal small-caps 20%/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "oblique expanded normal bolder xx-large/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "oblique extra-condensed 100 20%/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "oblique extra-condensed 20%/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "oblique lighter small-caps expanded xx-large/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "oblique normal 20%/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "oblique normal expanded small-caps 20%/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "oblique normal lighter small-caps xx-large/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "oblique normal normal 100 xx-large/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "oblique normal small-caps 900 20%/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "oblique small-caps lighter normal 20%/1.2 serif" should set the property value: FAIL
    e.style['font'] = "oblique small-caps normal normal xx-large/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "oblique small-caps semi-condensed 900 xx-large/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "small-caps 100 calc(30% - 40px)/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "small-caps bold oblique extra-condensed 20%/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "small-caps bolder condensed calc(30% - 40px)/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "small-caps bolder normal italic xx-large/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "small-caps condensed italic calc(30% - 40px)/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "small-caps expanded bolder xx-large/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "small-caps expanded xx-large/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "small-caps extra-condensed normal 900 20%/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "small-caps extra-expanded lighter normal larger/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "small-caps extra-expanded normal larger/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "small-caps italic bolder semi-expanded larger/calc(120% + 1.2em) monospace" should set the property value: FAIL
    e.style['font'] = "small-caps italic normal 100 calc(30% - 40px)/calc(120% + 1.2em) serif" should set the property value: FAIL
    e.style['font'] = "small-caps lighter normal ultra-condensed larger/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "small-caps normal bold oblique 20%/1.2 Menu" should set the property value: FAIL
    e.style['font'] = "small-caps normal bolder extra-expanded calc(30% - 40px)/calc(120% + 1.2em) \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "small-caps normal condensed lighter larger/calc(120% + 1.2em) fantasy" should set the property value: FAIL
    e.style['font'] = "small-caps normal extra-condensed italic xx-large/1.2 cursive" should set the property value: FAIL
    e.style['font'] = "small-caps normal italic expanded larger/calc(120% + 1.2em) cursive" should set the property value: FAIL
    e.style['font'] = "small-caps normal normal bolder 20%/1.2 monospace" should set the property value: FAIL
    e.style['font'] = "small-caps normal normal larger/calc(120% + 1.2em) sans-serif" should set the property value: FAIL
    e.style['font'] = "small-caps normal normal semi-expanded calc(30% - 40px)/calc(120% + 1.2em) Menu" should set the property value: FAIL
    e.style['font'] = "small-caps normal oblique lighter xx-large/1.2 sans-serif" should set the property value: FAIL
    e.style['font'] = "small-caps normal xx-large/1.2 serif" should set the property value: FAIL
    e.style['font'] = "small-caps oblique bold normal xx-large/1.2 fantasy" should set the property value: FAIL
    e.style['font'] = "small-caps oblique normal normal 20%/1.2 \"FB Armada\"" should set the property value: FAIL
    e.style['font'] = "small-caps oblique ultra-expanded lighter 20%/1.2 serif" should set the property value: FAIL
/css/cssom/font-shorthand-serialization.html
    The font shorthand should be serialized just like any other shorthand.: FAIL

(truncated for maximum comment length)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 8

•

5 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=28fffc80abee4b6153c7a9d202ae4ede10d91fce

Pulsebot

Comment 9

•

5 years ago

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4997dd1d3199
[wpt PR 19025] - CSS: Serialize font shorthand with spaces around '/', a=testonly

Cosmin Sabou [:CosminS]

Comment 10

•

5 years ago

bugherder landing

https://hg.mozilla.org/integration/mozilla-inbound/rev/4997dd1d3199

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 11

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/4997dd1d3199

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox71: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla71

Bugzilla

Quick Search

[wpt-sync] Sync PR 19025 - CSS: Serialize font shorthand with spaces around '/'

Categories

(Core :: Layout: Text and Fonts, task, P4)

Tracking

()

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Comment 1

Updated

Comment 2

Comment 3

Comment 4

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Comment 10

Comment 11