1580848 - Clean up some things in dom/ipc/tests/browser_crash_oopiframe.js

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

+++ This bug was initially created as a clone of Bug #1579716 +++

See kmag's review feedback in https://phabricator.services.mozilla.com/D45594#1379647.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Happy to mentor this if somebody wants to take a crack at it. Otherwise, I'll take care of this sometime next week.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Actually, it turns out I was halfway through cleaning this up in bug 1579692, so I can recycle some of it.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1580848 - Clean up some review feedback on the browser_crash_oopiframe.js test. r?kmag

• The test first asserts that we can actually load iframes in separate subprocesses
• The test now loads in a new tab rather than a new window
• The test no longer uses the "fission" attribute
• The test avoids the BrowsingContext.get pattern, in favour of just passing the
  BrowsingContext from one actor to the other directly.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1580848 - Add ContentTaskUtils to SpecialPowers.spawn execution scope. r?kmag

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5387cb607e45
Add ContentTaskUtils to SpecialPowers.spawn execution scope. r=kmag
https://hg.mozilla.org/integration/autoland/rev/f673fd22ace9
Clean up some review feedback on the browser_crash_oopiframe.js test. r=kmag

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5387cb607e45
https://hg.mozilla.org/mozilla-central/rev/f673fd22ace9