1580859 - Unable to recover password with keyboard

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Alex ARNAUD]

Tested environment:

• Firefox Nightly
• Debian 9 "Stretch" under Xorg and Debian Sid
• Firefox password manager is by default Firefox Lockwise

Steps to reproduce:

1. Open the password manager
2. Do a search in the search box
3. Enable keyboard navigation with F7
4. Tab until going on the result list
5. Press enter to display the first result of the list

Result:
I'm not sure exactly what's happening but Firefox Lockwise doesn't display the first item of the result list.

Expected result:
Firefox Lockwise should give the focus to first list item and pressing enter should display it.

Important note:
At this time, a keyboard user like a blind person couldn't recover a saved password since the switch to Lockwise.
I think this issue should be a high priority as having access to its password looks critical to me.

Best regards.

Comment 1

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1580859 - Keyboard navigation in the login-list should cycle through only visible login-list-items. r?MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a29d2c7cdbe3
Keyboard navigation in the login-list should cycle through only visible login-list-items. r=sfoster

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a29d2c7cdbe3

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 71.0a1 (Build ID: 20190918100042) (64-bit) on Windows 7, MacOS 10.14 and Arch Linux 4.14.

• The first saved login displayed in the list after performing a search is correctly selected if the list is focused and the "Enter" key is pressed.

Comment 6

[Alex ARNAUD]

I confirm that it works with the keyboard now but the Orca screen reader still doesn't read the result of the search when I tab on it.

@Jamie: Does it work with the NVDA screen reader?

Best regards.

Comment 7

[Alex ARNAUD]

It now looks that the enter key is too heavily captured, when I open the contextual-menu and choose "examine element" (translated from French) enter enable the item from the contextual menu and also enable the first item of the result list but I assume as the context is the contextual menu it shouldn't.

Best regards.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/bad933d2d8b3

Comment 9

[James Teh [:Jamie]]

(In reply to Alex ARNAUD from comment #6)

I confirm that it works with the keyboard now but the Orca screen reader still doesn't read the result of the search when I tab on it.

@Jamie: Does it work with the NVDA screen reader?

NVDA does read it, yes. There is some quirkiness though; the list box itself seems to get focus sometimes instead of an option within it. I'll take a look with Orca.

Comment 10

[James Teh [:Jamie]]

Alex, if you enter a search query, tab to the list and then press up arrow and then down arrow, do you get the result reported by Orca as you expect? (I'm not suggesting this is correct behaviour; just trying to verify we're seeing the same behaviour.)

Comment 11

[Alex ARNAUD]

(In reply to James Teh [:Jamie] from comment #10)

Alex, if you enter a search query, tab to the list and then press up arrow and then down arrow, do you get the result reported by Orca as you expect? (I'm not suggesting this is correct behaviour; just trying to verify we're seeing the same behaviour.)

Yes, it's exactly the behavior we're encountering.

Best regards.

Comment 12

[James Teh [:Jamie]]

(In reply to Alex ARNAUD from comment #11)

(In reply to James Teh [:Jamie] from comment #10)

Alex, if you enter a search query, tab to the list and then press up arrow and then down arrow, do you get the result reported by Orca as you expect? (I'm not suggesting this is correct behaviour; just trying to verify we're seeing the same behaviour.)

Yes, it's exactly the behavior we're encountering.

Thanks. I filed bug 1583425 for this.

Comment 13

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the Firefox Beta 70.0b9 (Build ID: 20190923154733) (64-bit) on Windows 7, MacOS 10.14 and Arch 4.14.

• The first saved login displayed in the list after performing a search is correctly selected if the list is focused and the "Enter" key is pressed.