Move toolkit/forgetaboutsite to toolkit/components/forgetaboutsite
Categories
(Toolkit :: Data Sanitization, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: johannh, Assigned: ratnabalidutta26)
References
Details
Attachments
(1 file)
Despite what https://bugzilla.mozilla.org/show_bug.cgi?id=799229#c5 says we have never given up on putting things into toolkit/components and it's irritating everyone that forgetaboutsite isn't in there.
We should just move it into components/
|
Assignee | |
Comment 1•4 years ago
|
||
Can I work on this?
|
Reporter | |
Comment 2•4 years ago
|
||
Sure! Please use hg mv for moving the files.
|
|
Assignee | |
Comment 3•4 years ago
|
||
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4a725668063 Move toolkit/forgetaboutsite to toolkit/components/forgetaboutsite r=johannh
|
||
Comment 5•4 years ago
|
||
Backed out changeset d4a725668063 (bug 1580870) for causing browser_clearplugindata.js
https://hg.mozilla.org/integration/autoland/rev/99fab49135441d30fb5fd32fb72fd97f990be88a
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d4a7256680630ff0398940f45dbbc7038252ebf9&test_paths=test%2Fbrowser%2Fbrowser_clearplugindata.js&selectedJob=298485103
log: https://treeherder.mozilla.org/logviewer.html#?job_id=298485103&repo=autoland
log: https://treeherder.mozilla.org/logviewer.html#?job_id=298485301&repo=autoland
|
|
Reporter | |
Comment 6•4 years ago
|
||
Hey Ratnabali, it looks like we forgot to update this path here, should be easy enough: https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/toolkit/forgetaboutsite/test/browser/browser_clearplugindata.js#12
Can you update the patch with that and set the checkin needed tag again?
Thanks!
|
|
Assignee | |
Comment 7•4 years ago
|
||
Hi Johannh, I updated the patch and added the checkin needed tag as instructed.
Could you please review it?
Thanks!
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/145183f126ca Move toolkit/forgetaboutsite to toolkit/components/forgetaboutsite r=johannh
|
|
Reporter | |
Comment 9•4 years ago
|
||
Seems good :)
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
Description
•