1580870 - Move toolkit/forgetaboutsite to toolkit/components/forgetaboutsite

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, task, P5)

Description

[Johann Hofmann [:johannh]]

Despite what https://bugzilla.mozilla.org/show_bug.cgi?id=799229#c5 says we have never given up on putting things into toolkit/components and it's irritating everyone that forgetaboutsite isn't in there.

We should just move it into components/

Comment 1

[Ratnabali Dutta]

Can I work on this?

Comment 2

[Johann Hofmann [:johannh]]

Sure! Please use hg mv for moving the files.

Comment 3

[Ratnabali Dutta]

Attachment: Bug 1580870 - Move toolkit/forgetaboutsite to toolkit/components/forgetaboutsite r=johannh

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4a725668063
Move toolkit/forgetaboutsite to toolkit/components/forgetaboutsite r=johannh

Comment 5

[Andrei Ciure[:aciure]]

Backed out changeset d4a725668063 (bug 1580870) for causing browser_clearplugindata.js
https://hg.mozilla.org/integration/autoland/rev/99fab49135441d30fb5fd32fb72fd97f990be88a

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d4a7256680630ff0398940f45dbbc7038252ebf9&test_paths=test%2Fbrowser%2Fbrowser_clearplugindata.js&selectedJob=298485103

log: https://treeherder.mozilla.org/logviewer.html#?job_id=298485103&repo=autoland

also: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-fis-e10s-11%2Cm-fis%28bc11%29&revision=d4a7256680630ff0398940f45dbbc7038252ebf9

log: https://treeherder.mozilla.org/logviewer.html#?job_id=298485301&repo=autoland

Comment 6

[Johann Hofmann [:johannh]]

Hey Ratnabali, it looks like we forgot to update this path here, should be easy enough: https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/toolkit/forgetaboutsite/test/browser/browser_clearplugindata.js#12

Can you update the patch with that and set the checkin needed tag again?

Thanks!

Comment 7

[Ratnabali Dutta]

Hi Johannh, I updated the patch and added the checkin needed tag as instructed.

Could you please review it?
Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/145183f126ca
Move toolkit/forgetaboutsite to toolkit/components/forgetaboutsite r=johannh

Comment 9

[Johann Hofmann [:johannh]]

Seems good :)

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/145183f126ca