1580883 - nsJSEnvironment uses a mix of NSPR and TimeStamp time APIs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Jon Coppeard (:jonco)]

It would probably be better to change this to use TimeStamp/TimeDuration where possible.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1580883 - Use TimeStamp/TimeDuration APIs instead of PRTime/PR_Now() in nsJSEnvironment.cpp r?mccr8

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1580883 - Use TimeDuration for constants in nsJSEnvironment.cpp r?mccr8

Depends on D45693

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1580883 - Use TimeDuration for remaining global in nsJSEnvironment.cpp r?mccr8

Depends on D45695

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1580883 - Use TimeDuration for CycleCollectorStats members r?mccr8

Depends on D45696

Comment 5

[Andrew McCreight [:mccr8]]

Great. I worked on some patches for this a few years ago, but I never got around to finishing them.

Comment 7

[Jon Coppeard (:jonco)]

(In reply to Andrew McCreight [:mccr8] from comment #5)
Cool. One question I had was should we be using TimeStamp::NowUnfuzzed() here? I don't think any of these timeouts are be observable by content, but maybe the greater resolution is unnecessary here.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d574f9c4457
Use TimeStamp/TimeDuration APIs instead of PRTime/PR_Now() in nsJSEnvironment.cpp r=mccr8
https://hg.mozilla.org/integration/autoland/rev/2139d06ac9d2
Use TimeDuration for constants in nsJSEnvironment.cpp r=mccr8
https://hg.mozilla.org/integration/autoland/rev/c23405648344
Use TimeDuration for remaining global in nsJSEnvironment.cpp r=mccr8
https://hg.mozilla.org/integration/autoland/rev/94c4e9a25f19
Use TimeDuration for CycleCollectorStats members r=mccr8

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1d574f9c4457
https://hg.mozilla.org/mozilla-central/rev/2139d06ac9d2
https://hg.mozilla.org/mozilla-central/rev/c23405648344
https://hg.mozilla.org/mozilla-central/rev/94c4e9a25f19