Disable PGO on beta/release opt builds
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox71 fixed)
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: mshal, Assigned: mshal)
References
Details
Attachments
(3 files)
After accidentally breaking 1-tier PGO builds (bug 1580497), I realized we still have some 1-tier PGO builds in automation on beta & release. Specifically, jobs like win32-opt that are non-PGO on central have MOZ_PGO=1 set in the mozconfig for beta & release, which turns them into 1-tier PGO jobs since we don't have the Taskcluster PGO chain enabled for opt builds.
We now have separate PGO-enabled (3-tier) shippable builds running on central+beta+release, so I'm going to suggest that we disable PGO on the opt builds for beta & release builds so that they are at least consistent with central.
Comment 1•5 years ago
|
||
I think largely, we should be mindful of what we're testing. I imagine most or all of our performance tests should be testing shippable builds, though I haven't verified if that's the case. Other than that caveat, I think turning off PGO on our beta+release opt builds should overall be a good change.
Assignee | ||
Comment 2•5 years ago
|
||
(In reply to Aki Sasaki [:aki] (he/him) (UTC-7) from comment #1)
I think largely, we should be mindful of what we're testing. I imagine most or all of our performance tests should be testing shippable builds, though I haven't verified if that's the case. Other than that caveat, I think turning off PGO on our beta+release opt builds should overall be a good change.
Good point, it looks like we have tests on shippable builds on both beta & release, and talos on shippable beta builds. I don't see any talos runs on release for any builds, which looks like it's intentional from the task definitions in talos.yml? In any case, I don't think we'll be losing test or talos coverage for what we have today by disabling PGO for these builds.
Assignee | ||
Comment 3•5 years ago
|
||
This file is no longer required, since taskcluster handles scheduling
PGO tasks.
Assignee | ||
Comment 4•5 years ago
|
||
Setting this flag still attempts to build with 1-tier PGO, unless we
detect that 3-tier PGO is enabled. Since we should be using 3-tier PGO
everywhere, the flag should be redundant in our automation mozconfigs.
It can still be used locally in a mozconfig to do a 1-tier PGO build.
Depends on D46069
Assignee | ||
Comment 5•5 years ago
|
||
Mozharness no longer drives building with PGO; it is all handled in
Taskcluster and the build system.
Depends on D46070
Pushed by mshal@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7496b7f8a1a6 Remove mozconfig.pgo; r=firefox-build-system-reviewers,chmanchester https://hg.mozilla.org/integration/autoland/rev/dddf2cc00b9d Remove MOZ_PGO from mozconfigs; r=glandium https://hg.mozilla.org/integration/autoland/rev/0f7a09641b5a Remove PGO settings from mozharness; r=firefox-build-system-reviewers,chmanchester
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7496b7f8a1a6
https://hg.mozilla.org/mozilla-central/rev/dddf2cc00b9d
https://hg.mozilla.org/mozilla-central/rev/0f7a09641b5a
Description
•