1580906 - Send Tab page actions menu differs from the FxA toolbar menu one

Status: VERIFIED FIXED

(Firefox :: Firefox Accounts, task)

Description

[Edouard Oger [:eoger]]

Ana's gonna come up with screenshots.

Comment 1

[Ana Medinac]

The copy between the two menu's is different.

We should change the copy in the "Page action" menu for Send Tab to mirror the copy in the FxA Account Tool bar menu. I've added screenshots below.

Comment 2

[Ana Medinac]

Attachment: CopyToChange.png

Comment 3

[Ana Medinac]

Attachment: RightCopy.png

Comment 4

[Edouard Oger [:eoger]]

Attachment: Bug 1580906 p1 - Update page action menu Send Tab copy.

Comment 5

[Edouard Oger [:eoger]]

Attachment: Bug 1580906 p2 - Update FxA buttons copy in menubar.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dab1e9ada47
p1 - Update page action menu Send Tab copy. r=vbudhram
https://hg.mozilla.org/integration/autoland/rev/ae5fe308e4b2
p2 - Update FxA buttons copy in menubar. r=vbudhram,fluent-reviewers,flod

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1580906) for failures in browser_page_action_menu.js CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=267288419&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=f13da717e206f0f01ae4fdcde6996a5f626ecc2f&revision=ae5fe308e4b2821ac682847e0ded23a7d50290a7

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267288419&repo=autoland&lineNumber=2117

Backout: https://hg.mozilla.org/integration/autoland/rev/50d2138a9e75a8437c266f4623eeb8ee0c8ff901

Comment 8

[Edouard Oger [:eoger]]

Looking, thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a607aed2776
p1 - Update page action menu Send Tab copy. r=vbudhram
https://hg.mozilla.org/integration/autoland/rev/e2526255d6c6
p2 - Update FxA buttons copy in menubar. r=vbudhram,fluent-reviewers,flod

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7a607aed2776
https://hg.mozilla.org/mozilla-central/rev/e2526255d6c6

Comment 11

[Vasilica Tamas, QA [:vtamas]]

Attachment: Sign in to Firefox 1.png

Comment 12

[Vasilica Tamas, QA [:vtamas]]

Attachment: Sign in to Firefox 2.png

Comment 13

[Vasilica Tamas, QA [:vtamas]]

This issue was verified as fixed on Firefox 71.0a1 (2019-10-10) under Windows 10 64bit and Mac OS X 10.14.6. "Sign in to Firefox..." option is successfully displayed in both Send tab to device Page Action menu and Tools menu.