1580926 - Turn off gfx.webrender.all.qualified before shipping Firefox 70

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

Same deal as bug 1564851

Comment 1

[Jessie [:jbonisteel] pls NI]

We want to do this so that we could potentially do a gradual roll-out of our WebRender target (Intel Windows 10 desktop with small screen) for 70

Comment 2

[Jessie [:jbonisteel] pls NI]

Liz, I believe you are the Relman contact for 70 - getting this on your radar. Let me know if there are any concerns

Comment 3

[Jessie [:jbonisteel] pls NI]

(In reply to Jessie [:jbonisteel] plz needinfo from comment #2)

Liz, I believe you are the Relman contact for 70 - getting this on your radar. Let me know if there are any concerns

Oops wrong bug, sorry - fixing now :)

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

When do you intend to land the patch to flip the pref, in the RC build? That would be the build on October 14.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Yes, in RC.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Jeff, can you attach the patch and request uplift? Anytime this weekend up till Sunday afternoon is fine.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1580926. Disable gfx.webrender.all.qualified by default.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9100943 [details]
Bug 1580926. Disable gfx.webrender.all.qualified by default.

Beta/Release Uplift Approval Request

• User impact if declined: This is needed for us to do a gradual rollout of WebRender on Intel
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9100943 [details]
Bug 1580926. Disable gfx.webrender.all.qualified by default.

OK for uplift to m-r for the 70 RC build.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Would we also need this on m-c?

Comment 11

[Jeff Muizelaar [:jrmuizel]]

(In reply to Liz Henry (:lizzard) from comment #10)

Would we also need this on m-c?

Nope.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/81d8f4e5ed3d93ff8f93b0f8ebab7e0ddf63b434

Comment 13

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This bug has been identified as part of a pilot on determining root causes of blocking and dot release drivers.

It needs a root-cause set for it. Please see the list at https://docs.google.com/document/d/1FFEGsmoU8T0N8R9kk-MXWptOPtXXXRRIe4vQo3_HgMw/.

Add the root cause as a whiteboard tag in the form [rca - <cause> ] and remove the rca-needed keyword.

If you have questions, please contact :tmaity.

Comment 14

[Jeff Muizelaar [:jrmuizel]]

This wasn't a defect so I don't think asking for a root cause makes sense.