1580963 - Sync servo stuff.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1580963 - Cherry-pick some servo changes from a rustc upgrade.

This cherry-picks from Servo commit 98e4a53b724.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1580963 - Cherry-pick style changes from servo's victor import.

https://github.com/servo/servo/pull/24165

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1580963 - Fix servo build and rustfmt recent changes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/773adf85740c
Cherry-pick some servo changes from a rustc upgrade.
https://hg.mozilla.org/integration/autoland/rev/ff80bc57d655
Cherry-pick style changes from servo's victor import.
https://hg.mozilla.org/integration/autoland/rev/0639f53912d9
Fix servo build and rustfmt recent changes.

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/773adf85740c
https://hg.mozilla.org/mozilla-central/rev/ff80bc57d655
https://hg.mozilla.org/mozilla-central/rev/0639f53912d9

Comment 6

[Mike Hommey [:glandium]]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/773adf85740c
Cherry-pick some servo changes from a rustc upgrade.

At least this is required on esr68 to fix building with rustc 1.43. Can you ask for an uplift?

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9092476 [details]
Bug 1580963 - Cherry-pick some servo changes from a rustc upgrade.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build fix with newer rust versions.
• User impact if declined: None
• Fix Landed on Version: 71
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This code is not even ran on Gecko, as Gecko doesn't parse the @viewport rule.
• String or UUID changes made by this patch: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9092476 [details]
Bug 1580963 - Cherry-pick some servo changes from a rustc upgrade.

No-op patch for Firefox needed to keep ESR building with newer Rust releases. Approved for 68.8esr RC2.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/9e0c6ecc6865