Closed Bug 1581008 Opened 5 years ago Closed 5 years ago

Support inactive CSS messages for :visited rule

Categories

(DevTools :: Inspector: Rules, enhancement)

Product:
DevTools
Component:
Inspector: Rules
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 6 obsolete files)

Bug 1581008: Add inactive CSS message for properties that are impossible to override. r?pbro!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1581008: Add test for :visited inactive CSS message. r?pbro!
47 bytes, text/x-phabricator-request
Details | Review

This is a followup of bug 713106.
After implementation to display/lock/unlock for :visited rule, we should support inactive CSS messages since :visited rule has very strict constraints.
https://developer.mozilla.org/docs/Web/CSS/:visited

Attachment #9092528 - Attachment description: Bug 1581008: Support inactive CSS messages. r?pbro! → Bug 1581008: Add inactive CSS message for properties that are impossible to override. r?pbro!
Attachment #9092529 - Attachment description: Bug 1581008: Add an inactive CSS message for the color which has alpha channel. r?pbro! → Bug 1581008: Add inactive CSS message that alpha channel of color is impossible to override. r?pbro!
Assignee: nobody → daisuke
Status: NEW → ASSIGNED

Depends on D46418

Attachment #9093806 - Attachment is obsolete: true
Attachment #9093805 - Attachment is obsolete: true
Attachment #9093804 - Attachment is obsolete: true
Attachment #9093803 - Attachment is obsolete: true
Blocks: 1583427
Attachment #9093519 - Attachment is obsolete: true
Attachment #9092529 - Attachment is obsolete: true
Blocks: 1583699
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d69f8f5f9db4
Add inactive CSS message for properties that are impossible to override. r=pbro,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/1208c70dd3bd
Add test for :visited inactive CSS message. r=pbro

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=1208c70dd3bd31c283c884a57000e2761fc09cb3&selectedJob=268307376

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268307376&repo=autoland&lineNumber=53641

Backout link: https://hg.mozilla.org/integration/autoland/rev/b88f44533c9731dc5d3cd7d25dc1a54a1c4bec96

[task 2019-09-25T08:29:18.801Z] 08:29:18 INFO - TEST-START | devtools/server/tests/mochitest/test_styles-matched.html
[task 2019-09-25T08:29:18.882Z] 08:29:18 INFO - GECKO(1897) | ++DOMWINDOW == 81 (0x1264bd400) [pid = 1897] [serial = 420] [outer = 0x128e24d40]
[task 2019-09-25T08:29:18.951Z] 08:29:18 INFO - GECKO(1897) | ++DOCSHELL 0x115e3b800 == 16 [pid = 1897] [id = {552f1737-008f-ac41-9e65-af870e4892bf}]
[task 2019-09-25T08:29:18.951Z] 08:29:18 INFO - GECKO(1897) | ++DOMWINDOW == 82 (0x122fe0b60) [pid = 1897] [serial = 421] [outer = 0x0]
[task 2019-09-25T08:29:18.952Z] 08:29:18 INFO - GECKO(1897) | ++DOMWINDOW == 83 (0x1267b1400) [pid = 1897] [serial = 422] [outer = 0x122fe0b60]
[task 2019-09-25T08:29:19.018Z] 08:29:19 INFO - GECKO(1897) | ++DOMWINDOW == 84 (0x128609c00) [pid = 1897] [serial = 423] [outer = 0x122fe0b60]
[task 2019-09-25T08:29:19.044Z] 08:29:19 INFO - GECKO(1897) | ++DOMWINDOW == 85 (0x125b7c400) [pid = 1897] [serial = 424] [outer = 0x122fe0b60]
[task 2019-09-25T08:29:19.930Z] 08:29:19 INFO - GECKO(1897) | console.error: "Error writing response to: getMatchedSelectors"
[task 2019-09-25T08:29:19.940Z] 08:29:19 INFO - GECKO(1897) | console.error: "Error while calling actor 'pagestyle's method 'getMatchedSelectors'" "Argument 1 of InspectorUtils.getContentState is not an object."
[task 2019-09-25T08:29:19.940Z] 08:29:19 INFO - GECKO(1897) | console.error: "hasVisitedState@resource://devtools/shared/inspector/css-logic.js:564:23\nisVisitedRule@resource://devtools/server/actors/utils/inactive-property-helper.js:665:19\nwhen@resource://devtools/server/actors/utils/inactive-property-helper.js:222:26\nisPropertyUsed/<@resource://devtools/server/actors/utils/inactive-property-helper.js:308:21\nisPropertyUsed@resource://devtools/server/actors/utils/inactive-property-helper.js:292:21\nform/form.declarations<@resource://devtools/server/actors/styles.js:1447:46\nform@resource://devtools/server/actors/styles.js:1442:40\nwrite@resource://devtools/shared/protocol/types.js:358:32\ntypes.addArrayType/write/<@resource://devtools/shared/protocol/types.js:220:33\nwrite@resource://devtools/shared/protocol/types.js:220:16\nwrite@resource://devtools/shared/protocol/types.js:268:39\nwrite@resource://devtools/shared/protocol/Response.js:98:22\nwrite@resource://devtools/shared/protocol/Response.js:43:28\nsendReturn@resource://devtools/shared/protocol/Actor.js:164:38\npromise callbackgenerateRequestHandlers/</handler/<@resource://devtools/shared/protocol/Actor.js:186:14\n_queueResponse@resource://devtools/shared/protocol/Actor.js:107:28\nhandler@resource://devtools/shared/protocol/Actor.js:183:14\nonPacket@resource://devtools/server/debugger-server-connection.js:378:58\nreceiveMessage@resource://devtools/shared/transport/child-transport.js:66:16\nMessageListener.receiveMessage_addListener@resource://devtools/shared/transport/child-transport.js:40:14\nready@resource://devtools/shared/transport/child-transport.js:57:10\n_onConnection@resource://devtools/server/debugger-server.js:450:15\nconnectToParent@resource://devtools/server/debugger-server.js:331:17\nonConnect<@resource://devtools/server/startup/frame.js:62:35\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\nMessageListener.receiveMessage*@resource://devtools/server/startup/frame.js:92:23\n@resource://devtools/server/startup/frame.js:174:5\nconnectToFrame/<@resource://devtools/server/connectors/frame-connector.js:45:8\nconnectToFrame@resource://devtools/server/connectors/frame-connector.js:41:10\nconnect@resource://devtools/server/actors/targets/frame-proxy.js:65:35\nasyncBrowserTabList.prototype._getActorForBrowser@resource://devtools/server/actors/webbrowser.js:368:16\nBrowserTabList.prototype.getTab@resource://devtools/server/actors/webbrowser.js:388:21\nonGetTab@resource://devtools/server/actors/root.js:364:35\nonPacket@resource://devtools/server/debugger-server-connection.js:378:58\nsend/<@resource://devtools/shared/transport/local-transport.js:70:25\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\nDevToolsUtils.executeSoonexports.executeSoon@resource://devtools/shared/DevToolsUtils.js:62:21\nsend@resource://devtools/shared/transport/local-transport.js:58:21\nsend@resource://devtools/shared/protocol/Front.js:164:30\nrequest@resource://devtools/shared/protocol/Front.js:182:10\ngenerateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:49:19\ngetTab@resource://devtools/shared/fronts/root.js:329:30\ncreateTargetForTab@resource://devtools/client/framework/target.js:94:28\nasyncforTab@resource://devtools/client/framework/target.js:40:26\ngetTargetForSelectedTab@chrome://mochitests/content/chrome/devtools/server/tests/mochitest/inspector-helpers.js:50:24\nasyncattachURL@chrome://mochitests/content/chrome/devtools/server/tests/mochitest/inspector-helpers.js:74:24\nasyncsetup@chrome://mochitests/content/chrome/devtools/server/tests/mochitest/test_styles-matched.html:29:33\nrunNextTest@chrome://mochitests/content/chrome/devtools/server/tests/mochitest/inspector-helpers.js:152:5\nwindow.onload@chrome://mochitests/content/chrome/devtools/server/tests/mochitest/test_styles-matched.html:20:3\nEventHandlerNonNull@chrome://mochitests/content/chrome/devtools/server/tests/mochitest/test_styles-matched.html:18:1\n"
[task 2019-09-25T08:29:20.039Z] 08:29:20 INFO - TEST-INFO | started process screencapture
[task 2019-09-25T08:29:20.166Z] 08:29:20 INFO - TEST-INFO | screencapture: exit 0
[task 2019-09-25T08:29:20.167Z] 08:29:20 INFO - TEST-UNEXPECTED-FAIL | devtools/server/tests/mochitest/test_styles-matched.html | Promise failed: Protocol error (unknownError): Argument 1 of InspectorUtils.getContentState is not an object.
[task 2019-09-25T08:29:20.167Z] 08:29:20 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:277:18
[task 2019-09-25T08:29:20.167Z] 08:29:20 INFO - promiseDone/<@chrome://mochitests/content/chrome/devtools/server/tests/mochitest/inspector-helpers.js:102:7
[task 2019-09-25T08:29:20.167Z] 08:29:20 INFO - GECKO(1897) | MEMORY STAT | vsize 7947MB | residentFast 648MB | heapAllocated 230MB
[task 2019-09-25T08:29:20.167Z] 08:29:20 INFO - GECKO(1897) | [Parent 1897, Main Thread] WARNING: '!wgc', file /builds/worker/workspace/build/src/dom/ipc/JSWindowActorService.cpp, line 177
[task 2019-09-25T08:29:20.258Z] 08:29:20 INFO - TEST-OK | devtools/server/tests/mochitest/test_styles-matched.html | took 1458ms

Flags: needinfo?(daisuke)
Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/887394ac57bc
Add inactive CSS message for properties that are impossible to override. r=pbro,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/5249dd6e05b5
Add test for :visited inactive CSS message. r=pbro

https://hg.mozilla.org/mozilla-central/rev/887394ac57bc
https://hg.mozilla.org/mozilla-central/rev/5249dd6e05b5

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Regressions: 1589858
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: