1581014 - about:logins list item selection can go directly to edit mode

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[David Durst [:ddurst]]

If I'm going through the login list (using the keyboard), pressing Enter will select the item and put focus on the login-item's edit button, as reported in 1576026.

But if instead of pressing Enter, I press Space, it immediately pulls up the login-item in Edit mode.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1581014 - Select the login item on keyup instead of keydown to prevent the 'Edit' button, which gets focused on login selection, from getting an erroneous click event. r?MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a2fac1bae9d
Select the login item on keyup instead of keydown to prevent the 'Edit' button, which gets focused on login selection, from getting an erroneous click event. r=MattN

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4a2fac1bae9d

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20190918100042) (64-bit) on Windows 7, MacOS 10.14 and Arch Linux 4.14.

• The focused saved login is no longer opened directly in "Edit" mode if pressing the "Space".

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4ab638589c80

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the Firefox Beta 70.0b9 (Build ID: 20190923154733) (64-bit) on Windows 7, MacOS 10.14 and Arch 4.14.

• The focused saved login is no longer opened directly in "Edit" mode if pressing the "Space".