Closed Bug 1581060 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19041 - Revert "[LayoutNG] Fix incorrect rounding in ShapingLineBreaker"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19041 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19041
Details from upstream follow.

Ioana Pandele <ioanap@chromium.org> wrote:

Revert "[LayoutNG] Fix incorrect rounding in ShapingLineBreaker"

This reverts commit a4d21f7f7faa39ce99f96b81996b6ece702f501e.

Reason for revert: This is likely breaking

  • external/wpt/css/css-multicol/multicol-width-ch-001.xht
  • css2.1/t1602-c546-txt-align-00-b.html
  • external/wpt/css/css-text/white-space/trailing-space-align-start.tentative.html

Original change's description:

[LayoutNG] Fix incorrect rounding in ShapingLineBreaker

This patch fixes the rounding the end position to the same
direction as the rounding the start position. Before this
change, the end position was rounded to the line-end
direction. This may have resulted in slightly larger
available space than the given one.

Although the error is slight, such an error can cause a large
visual differences because of an optimization. |NGLineBreaker|
determines the overflow by comparing the result width to the
available width, and if overflow occurs, it assumes that it
cannot break the result further when it tries to rewind.

Bug: 1002442
Change-Id: Iebee80117c9930eade029c45c561236b8916981a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797954
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Commit-Queue: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696262}

TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org

Change-Id: Ie9255f9bfc01427550d58d92135b4ce25db27583
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801769
Reviewed-by: Ioana Pandele \<ioanap@chromium.org>
Commit-Queue: Ioana Pandele \<ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696316}

PR 19041 applied with additional changes from upstream: 8893b1bcfc2ca0675f4e81cd8b2a694ab14418cf
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/804dc64dffee
[wpt PR 19041] - Revert "[LayoutNG] Fix incorrect rounding in ShapingLineBreaker", a=testonly
Result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/804dc64dffee

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.