Closed Bug 1581064 Opened 6 years ago Closed 5 years ago

Crash in [@ shutdownhang | mozilla::jsinspector::nsJSInspector::EnterNestedEventLoop] via nsPgpMimeProxy::Finish for Enigmail users

Categories

(Thunderbird :: General, defect)

x86
Windows
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: wsmwk, Unassigned)

Details

(Keywords: crash, topcrash-thunderbird)

Crash Data

I tend not to file bugs for shutdown hangs, but this is a topcrash (and on the rise) and perhaps something can be done with it. https://crash-stats.mozilla.com/signature/?product=Thunderbird&signature=shutdownhang%20%7C%20mozilla%3A%3Ajsinspector%3A%3AnsJSInspector%3A%3AEnterNestedEventLoop&date=%3E%3D2019-08-13T09%3A02%3A00.000Z&date=%3C2019-09-13T09%3A02%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#graphs

bp-2f6f1397-511e-491f-a398-718ae0190913 68.1.0

Top 10 frames of crashing thread:

0 ntdll.dll NtWaitForAlertByThreadId 
1 ntdll.dll RtlSleepConditionVariableSRW 
2 kernelbase.dll SleepConditionVariableSRW 
3 mozglue.dll mozilla::detail::ConditionVariableImpl::wait mozglue/misc/ConditionVariable_windows.cpp:50
4 xul.dll mozilla::ThreadEventQueue<mozilla::PrioritizedEventQueue<mozilla::EventQueue> >::GetEvent xpcom/threads/ThreadEventQueue.cpp:149
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1108
6 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
7 xul.dll mozilla::jsinspector::nsJSInspector::EnterNestedEventLoop devtools/platform/nsJSInspector.cpp:75
8 xul.dll NS_InvokeByIndex 
9 xul.dll XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1158

bp-59bcc3ac-fa45-44c7-97f2-385530190913 68.0

See Also: → 1485802

This correlates to Enigmail, and also to the decrease at end of october to an update of of version 2.1.3. So not bug 1485802

Looks like another decrease in the last few days, but I don't see any Enigmail updates so I don't know why the decrease (if the decrease continues)

bp-7405851c-820c-48fd-9eb7-3d62d0191115 68.2.1

Flags: needinfo?(patrick)
See Also: 1485802

I honestly don't have an idea why the crash rate decreased suddenly. There were quite a number of changes between Enigmail 2.1.2 and 2.1.3, but none of them was related to gpg execution (and this is what the crashes are about).

Flags: needinfo?(patrick)

Both crash rate decreases were mid-week, Oct 31 (dropped ~70%), and Nov 13-14 [1]. We shipped 68.2.1 the afternoon of oct 31 at rate 100. Monday-Wed of that week had ~400 crashes for 68.2.0. The following two weeks the combination of 68.2.1+68.2.2 never got above 190. But I have no method with crash-stats to determine which version change had the most effect - Thunderbird or Enigmail.

The crashes would seem to correlte to nsPgpMimeProxy::Finish() bp-2780bf3f-8f4d-43d6-a870-db3ce0191113

[1] https://crash-stats.mozilla.com/signature/?product=Thunderbird&signature=shutdownhang%20%7C%20mozilla%3A%3Ajsinspector%3A%3AnsJSInspector%3A%3AEnterNestedEventLoop&date=%3E%3D2019-10-17T12%3A48%3A00.000Z&date=%3C2019-11-17T12%3A48%3A00.000Z#graphs

Summary: Crash in [@ shutdownhang | mozilla::jsinspector::nsJSInspector::EnterNestedEventLoop] → Crash in [@ shutdownhang | mozilla::jsinspector::nsJSInspector::EnterNestedEventLoop] via nsPgpMimeProxy::Finish for Enigmail users
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME

Don't forget that Enigmail does not work anymore on TB 72 and newer...

Windows 8.1 (64bit) , Thunderbird 68.8.0 (32-Bit)
crash while Screensaver was active.

bp-f712caae-e856-47c3-8743-330e80200519

Crashing Thread (0)
Frame Module Signature Source Trust
0 ntdll.dll NtWaitForAlertByThreadId context
1 ntdll.dll RtlSleepConditionVariableSRW cfi
2 kernelbase.dll SleepConditionVariableSRW cfi
3 mozglue.dll mozilla::detail::ConditionVariableImpl::wait(mozilla::detail::MutexImpl&) mozglue/misc/ConditionVariable_windows.cpp:50 cfi
4 xul.dll mozilla::ThreadEventQueue<mozilla::PrioritizedEventQueue<mozilla::EventQueue> >::GetEvent(bool, mozilla::EventQueuePriority*) xpcom/threads/ThreadEventQueue.cpp:149 cfi
5 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp:1108 cfi
6 xul.dll NS_ProcessNextEvent(nsIThread*, bool) xpcom/threads/nsThreadUtils.cpp:486 cfi
7 xul.dll mozilla::jsinspector::nsJSInspector::EnterNestedEventLoop(JS::Handle<JS::Value>, unsigned int*) devtools/platform/nsJSInspector.cpp:75 cfi
8 xul.dll NS_InvokeByIndex cfi
9 xul.dll XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) js/xpconnect/src/XPCWrappedNative.cpp:1158 frame_pointer
10 xul.dll XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) js/xpconnect/src/XPCWrappedNativeJSOps.cpp:946 cfi
11 xul.dll js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) js/src/vm/Interpreter.cpp:535 cfi
12 xul.dll static bool InternalCall(struct JSContext*, const class js::AnyInvokeArgs& const) js/src/vm/Interpreter.cpp:590 cfi
13 xul.dll static bool Interpret(struct JSContext*, class js::RunState& const) js/src/vm/Interpreter.cpp:3082 cfi
14 xul.dll js::RunScript(JSContext*, js::RunState&) js/src/vm/Interpreter.cpp:423 cfi
15 xul.dll js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) js/src/vm/Interpreter.cpp:563 cfi
16 xul.dll static bool InternalCall(struct JSContext*, const class js::AnyInvokeArgs& const) js/src/vm/Interpreter.cpp:590 cfi
17 xul.dll js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) js/src/vm/Interpreter.cpp:606 cfi
18 xul.dll js::jit::InvokeFunction(JSContext*, JS::Handle<JSObject*>, bool, bool, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) js/src/jit/VMFunctions.cpp:260 cfi
19 xul.dll js::jit::InvokeFromInterpreterStub(JSContext*, js::jit::InterpreterStubExitFrameLayout*) js/src/jit/VMFunctions.cpp:289 cfi
20 xul.dll truncf cfi_scan

You need to log in before you can comment on or make changes to this bug.