Closed Bug 1581087 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19043 - [LayoutNG] Use BoxLayoutExtraInput when calculating overflow.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19043 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19043
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[LayoutNG] Use BoxLayoutExtraInput when calculating overflow.

This will set temporary proper override sizes.

We already use this mechanism in NGBlockNode::RunLegacyLayout(), but
that one only has an effect for things that are done from within legacy
layout (LayoutObject::Layout()). Overflow calculation happens after
layout, and is done by the legacy engine, even for NG objects.

Bug: 908083
Change-Id: I2b4e88c096f138aa820856e3c79e1ddcef07a3da
Reviewed-on: https://chromium-review.googlesource.com/1801770
WPT-Export-Revision: 4e5a7047252f681e0660d48dc5fce98f88d76a34

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 2 tests and 2 subtests
OK     : 2
PASS   : 1[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview], 2[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
FAIL   : 1[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]

New tests that have failures or other problems:
/css/CSS2/positioning/relpos-percentage-top-in-scrollable.html
    Top percentage resolved correctly for overflow contribution: FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/112fbc085937
[wpt PR 19043] - [LayoutNG] Use BoxLayoutExtraInput when calculating overflow., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/2929bbfc88d6
[wpt PR 19043] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.