158115 - workAroundAIXJavaBug in jsj.c breaks Java plugin on AIX

Status: VERIFIED FIXED

(Core Graveyard :: Java: Live Connect, defect)

Description

[Philip K. Warren]

In mozilla/js/src/liveconnect/jsj.c, there is a method workAroundAIXJavaBug 
which is called to "work around a bug in AIX JDK1.1.6". This method is found in 
mozilla/js/src/liveconnect/classes/netscape/javascript/JSUtil.java, however it 
is not included in any of the Java Plugin filesets for AIX. This causes Mozilla 
to try and call the workAroundAIXJavaBug method, and when that method is not 
found, it causes the Java Plugin to crash. I have a testcase available to 
illustrate the problem.

I have spoken to the IBM Java developers and they feel that this workaround is 
no longer relevant to more recent versions of the Java Plugin.

Comment 1

[Philip K. Warren]

Attachment: test1.class

Comment 2

[Philip K. Warren]

Attachment: test1.html

Comment 3

[Philip K. Warren]

Attachment: test1.java

Comment 4

[Philip K. Warren]

To reproduce the crash, download test1.class and test1.html which are attached 
to this bug and place them in the same directory. Then start Mozilla (with the 
Java Plugin installed) and view test1.html in the browser.

Comment 5

[Philip K. Warren]

Attachment: Removed workAroundAIXJavaBug from liveconnect

Comment 6

[Phil Schwartau]

Reassigning to Patrick as the de facto owner of LiveConnect.

Note he is away on sabbatical at the moment. Therefore cc'ing 
Brendan, [e-mail] for possible sr=, r= of the patch
submitted here -

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 91816 [details] [diff] [review]
Removed workAroundAIXJavaBug from liveconnect

sr=[e-mail], let's get this in.

/be

Comment 8

[rogerl (gone)]

Comment on attachment 91816 [details] [diff] [review]
Removed workAroundAIXJavaBug from liveconnect

r=rogerl

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 91816 [details] [diff] [review]
Removed workAroundAIXJavaBug from liveconnect

a=asa (on behalf of drivers) for checkin to 1.1

Comment 10

[Brendan Eich [:brendan]]

Beard's still out, IIRC -- who will check this fix into the trunk?

/be

Comment 11

[Jim Dunn]

Sorry, I should have done this sooner.
I grabbed ownership (but put beard in the cc list)
I will check it in tomorrow AM

Comment 12

[Jim Dunn]

fix checked into trunk

Comment 13

[Phil Schwartau]

Jim: I'm not familiar with the "fixedOEM" keyword; is this patch
going to be checked into the 1.1 branch ("fixed1.0.1" keyword)?

My understanding is that this is -rMOZILLA_1_0_BRANCH in CVS.

Comment 14

[Phil Schwartau]

Jim explained to me that this fix should go onto the trunk,
(where it will make the 1.1 branch), and the NETSCAPE_7_0_OEM_BRANCH,
which is what "fixedOEM" means.

Patch verified there and on the trunk; provisionally marking Verified.

[e-mail]: could you confirm that this fixed the problem?
I have no trouble running your testcase on WinNT, but I don't have
an AIX box; thanks -