1581155 - Following the link from the box-model to the rule-view does not flash the CSS property anymore

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Patrick Brosset <:pbro>]

In bug 1493677 we add a new feature to link box-model values to their corresponding authored styles in the rule-view (only enabled in nightly now).
When the link is followed, the style in the rule-view gets highlighted in yellow briefly to draw attention.
This flashing does not work anymore.

Try this:

• open the inspector on this page (using nightly)
• select an element that has some padding, border or margin
• hold shift and hover over one of the padding, border or margin values in the box-model
• look at the rule-view

The rule-view automatically scrolls to reveal where the property is defined.
But the property is not flashed as it should.

Comment 1

[Micah [:mtigley] (she/her)]

Attachment: Bug 1581155 - Fix flashing a CSS property from box-model link.

In this revision, mimic flashing a property element like in the markup view.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17eb7c5a88c4
Fix flashing a CSS property from box-model link. r=gl

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/17eb7c5a88c4

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider uplifting to Beta?

Comment 5

[Micah [:mtigley] (she/her)]

Yes, let's uplift this fix.

Comment 6

[Micah [:mtigley] (she/her)]

Comment on attachment 9092735 [details]
Bug 1581155 - Fix flashing a CSS property from box-model link.

Beta/Release Uplift Approval Request

• User impact if declined: Users will not see the yellow highlight when scrolling to the selected CSS property.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor fix
• String changes made/needed:

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9092735 [details]
Bug 1581155 - Fix flashing a CSS property from box-model link.

Fix for regression from 67, looks straightforward.
OK for uplift for beta 9.

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e41b9f16b581