Closed Bug 1581305 Opened 4 months ago Closed 4 months ago

remove <observes> usage from mail/

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(2 files, 2 obsolete files)

The ones for quickfilter.

Attachment #9093101 - Flags: review?(paul)

The ones for compose. With this, we'll still have observes attributes. But one step ahead.

Very green try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ddbd3e431262102c43da223a0655fe8084dbebf1

Attachment #9093102 - Flags: review?(paul)
Comment on attachment 9093101 [details] [diff] [review]
bug1581305_observes_qf.mail.patch

Review of attachment 9093101 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, I tested each of the 3 places where you can toggle the quickfilter toolbar, and it is still shown and hidden correctly and the toggles all get updated correctly as checked or not.  r+ with a docstring added for the new function.

::: mail/base/content/quickFilterBar.js
@@ +90,5 @@
>  
>      this._updateCommands();
>    },
>  
> +  _setupToggleChecks(checked) {

A brief doc string for this function would be good here.
Attachment #9093101 - Flags: review?(paul) → review+
Comment on attachment 9093102 [details] [diff] [review]
bug1581305_observes_compose.mail.patch

Review of attachment 9093102 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r+ with a couple doc comments added.  I tested it and all the various composer buttons/widgets were getting updated correctly.

::: mail/components/compose/content/ComposerCommands.js
@@ +366,4 @@
>    }
>  }
>  
>  function pokeStyleUI(uiID, aDesiredState) {

Could you add a doc comment?  Would be good to doc these parameters while we're here.

@@ +419,5 @@
>    }
>    return typedarray;
>  }
>  
>  function pokeMultiStateUI(uiID, cmdParams) {

Same, would be good to add a doc comment while we're here.
Attachment #9093102 - Flags: review?(paul) → review+
Attachment #9093102 - Attachment is obsolete: true
Attachment #9093822 - Flags: review+
Attachment #9093101 - Attachment is obsolete: true
Attachment #9093823 - Flags: review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e275a70046e0
remove <observes> usage from mail/: remove the ones related to cmd_toggleQuickFilterBar. r=pmorris
https://hg.mozilla.org/comm-central/rev/f5158588080a
remove <observes> usage from mail/: remove compose related usage of <observes>. r=pmorris

Keywords: checkin-needed
Target Milestone: --- → Thunderbird 71.0
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.