1581305 - remove <observes> usage from mail/

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

Remove <observes> usage from mail/

https://searchfox.org/comm-central/search?q=%3Cobserves&case=false&regexp=false&path=mail

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1581305_observes_qf.mail.patch

The ones for quickfilter.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1581305_observes_compose.mail.patch

The ones for compose. With this, we'll still have observes attributes. But one step ahead.

Very green try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ddbd3e431262102c43da223a0655fe8084dbebf1

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9093101 [details] [diff] [review]
bug1581305_observes_qf.mail.patch

Review of attachment 9093101 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, I tested each of the 3 places where you can toggle the quickfilter toolbar, and it is still shown and hidden correctly and the toggles all get updated correctly as checked or not.  r+ with a docstring added for the new function.

::: mail/base/content/quickFilterBar.js
@@ +90,5 @@
>  
>      this._updateCommands();
>    },
>  
> +  _setupToggleChecks(checked) {

A brief doc string for this function would be good here.

Comment 4

[Paul Morris [:pmorris]]

Comment on attachment 9093102 [details] [diff] [review]
bug1581305_observes_compose.mail.patch

Review of attachment 9093102 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r+ with a couple doc comments added.  I tested it and all the various composer buttons/widgets were getting updated correctly.

::: mail/components/compose/content/ComposerCommands.js
@@ +366,4 @@
>    }
>  }
>  
>  function pokeStyleUI(uiID, aDesiredState) {

Could you add a doc comment?  Would be good to doc these parameters while we're here.

@@ +419,5 @@
>    }
>    return typedarray;
>  }
>  
>  function pokeMultiStateUI(uiID, cmdParams) {

Same, would be good to add a doc comment while we're here.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: bug1581305_observes_compose.mail.patch

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: bug1581305_observes_qf.mail.patch

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e275a70046e0
remove <observes> usage from mail/: remove the ones related to cmd_toggleQuickFilterBar. r=pmorris
https://hg.mozilla.org/comm-central/rev/f5158588080a
remove <observes> usage from mail/: remove compose related usage of <observes>. r=pmorris